Closed 8bitzz closed 3 years ago
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/further-web/cosc-2769-rmit/GV93R2mWwBcx297JGqw8SYegFiqy
✅ Preview: https://cosc-2769-rmit-git-feat-forgot-password-further-web.vercel.app
Hi @8bitzz most of the functions tested good. However, I would suggest you add additional logic to protect the route /user/forgot-password
route so as users who have not logged in can't access the page.
@ManPhamQuang The current routes /user/forgot-password
& /user/reset-password
can be accessed by non-authenticated users only since I only implemented the feature Forgot Password & Reset Password for users who can't remember password to log into their account (non-authenticated users). Do you mean to implement the Reset Password for authenticated users also? In that case, we can create another ticket & implement it in the User Profile Page + Expert Profile Page
sorry @8bitzz my mistake, I thought the route /user/reset-password
should be protected from non-authenticated users, but now that I think about it, it wouldn't make any sense! I'll ask @dangvuthang to review this PR to ensure that it works and then I would approve this branh. Great work 👍
The functionality works great as expected. Good job, @8bitzz
Change-log
Forgot password
&Reset Password
to allow users to reset their passwordusers/request-reset-password
&users/reset-password
NavBar
componentHow-to-test
Forgot password
link to navigate to Forgot Password pagehttps://cosc-2769-rmit.vercel.app/user/reset-password?
tolocalhost:3000/user/reset-password?
/user/forgot-password
OR/user/reset-password
after logging in