ManageIQ / manageiq-providers-ibm_cic

Apache License 2.0
1 stars 11 forks source link

CIC name in dashboard is the "type" column exploded out #25

Closed Fryguy closed 1 year ago

Fryguy commented 1 year ago

Fullscreen_11_30_22__4_12_PM

This might also be present on other "new" providers. I checked Amazon and that looked ok. I'm not exactly sure where to fix this, so opening a bug.

agrare commented 1 year ago

I actually don't know where this is coming from either, @jeffibm do you know?

jeffibm commented 1 year ago

I actually don't know where this is coming from either, @jeffibm do you know?

No, but let's find out..

miq-bot commented 1 year ago

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

Fryguy commented 1 year ago

This is still an issue.

DavidResende0 commented 1 year ago

Looks like this is an issue for the VPC provider as well

Screenshot 2023-05-23 at 10 41 49 AM
jeffibm commented 1 year ago

Debugging -

For this particular tooltip- ManageIQ/Providers/Google/Cloud Manager is being rendered from Quaditem.jsx#L60

image

We get the data from a request /ems_cloud_dashboard/aggregate_status_data/17

image

and it goes here - EmsCloudDashboardService > aggregate_status_data

(The aggregate_status_data method is available in other controllers as well)

Fryguy commented 1 year ago

That leads to the quadicon_hash method which is here: https://github.com/ManageIQ/manageiq-decorators/blob/master/app/helpers/quadicon_helper.rb

akhilkr128 commented 1 year ago

From the quadicon_hash method execution will move to the corresponding decorator function. Like here https://github.com/ManageIQ/manageiq-decorators/blob/d32a9713e7e780519c4252607740a7879f8c56eb/app/decorators/manageiq/providers/cloud_manager_decorator.rb#L26. The ui_lookup will look for a key in the locale/en.yml file. I have added a key for google cloud provider as ManageIQ::Providers::Google::CloudManager: Google it gave me the below results.

Screenshot 2023-06-14 at 4 34 26 PM

Any other suggestions for this issue? @jeffibm, @Fryguy, @agrare

agrare commented 1 year ago

@akhilkr128 I see so we need something like https://github.com/ManageIQ/manageiq/blob/master/locale/en.yml#L1540 but for CIC / Google / etc...? We should go through all of the providers because I'm sure a number of others are missing.

@Fryguy is locale something that is pluggable? Can providers bring e.g. ManageIQ::Providers::Amazon::CloudManager: Cloud Provider (Amazon) in their own engine?

Fryguy commented 1 year ago

Unfortunately I don't think those i18n locales are pluggable, but It might be easy to do. For now, let's just get a PR updating the core repo's list

Fryguy commented 1 year ago

Alternatively, we might want to switch away from ui_lookup and move to normal gettext i18n + method calls

akhilkr128 commented 1 year ago

PR Created- https://github.com/ManageIQ/manageiq/pull/22572