Closed Fryguy closed 1 year ago
I actually don't know where this is coming from either, @jeffibm do you know?
I actually don't know where this is coming from either, @jeffibm do you know?
No, but let's find out..
This issue has been automatically marked as stale because it has not been updated for at least 3 months.
If you can still reproduce this issue on the current release or on master
, please reply with all of the information you have about it in order to keep the issue open.
Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.
This is still an issue.
Looks like this is an issue for the VPC provider as well
Debugging -
For this particular tooltip- ManageIQ/Providers/Google/Cloud Manager
is being rendered from Quaditem.jsx#L60
We get the data from a request /ems_cloud_dashboard/aggregate_status_data/17
and it goes here - EmsCloudDashboardService > aggregate_status_data
(The aggregate_status_data
method is available in other controllers as well)
That leads to the quadicon_hash method which is here: https://github.com/ManageIQ/manageiq-decorators/blob/master/app/helpers/quadicon_helper.rb
From the quadicon_hash
method execution will move to the corresponding decorator function. Like here https://github.com/ManageIQ/manageiq-decorators/blob/d32a9713e7e780519c4252607740a7879f8c56eb/app/decorators/manageiq/providers/cloud_manager_decorator.rb#L26. The ui_lookup
will look for a key in the locale/en.yml
file. I have added a key for google cloud provider as ManageIQ::Providers::Google::CloudManager: Google
it gave me the below results.
Any other suggestions for this issue? @jeffibm, @Fryguy, @agrare
@akhilkr128 I see so we need something like https://github.com/ManageIQ/manageiq/blob/master/locale/en.yml#L1540 but for CIC / Google / etc...? We should go through all of the providers because I'm sure a number of others are missing.
@Fryguy is locale something that is pluggable? Can providers bring e.g. ManageIQ::Providers::Amazon::CloudManager: Cloud Provider (Amazon)
in their own engine?
Unfortunately I don't think those i18n locales are pluggable, but It might be easy to do. For now, let's just get a PR updating the core repo's list
Alternatively, we might want to switch away from ui_lookup and move to normal gettext i18n + method calls
PR Created- https://github.com/ManageIQ/manageiq/pull/22572
This might also be present on other "new" providers. I checked Amazon and that looked ok. I'm not exactly sure where to fix this, so opening a bug.