Move security test suite code out of rake and into an .rb file

[Fryguy]

Straight refactoring. Follow up to #23098

@jrafanie Please review.

[miq-bot]

Some comments on commit https://github.com/Fryguy/manageiq/commit/aa1d804e6e8b6752eb821e4b2bd3bced7b2ffdd2

lib/tasks/test_security_helper.rb

• [ ] :warning: - 16 - Detected puts. Remove all debugging statements.
• [ ] :warning: - 17 - Detected puts. Remove all debugging statements.
• [ ] :warning: - 18 - Detected puts. Remove all debugging statements.
• [ ] :warning: - 42 - Detected puts. Remove all debugging statements.
• [ ] :warning: - 54 - Detected puts. Remove all debugging statements.
• [ ] :warning: - 71 - Detected puts. Remove all debugging statements.
• [ ] :warning: - 73 - Detected puts. Remove all debugging statements.
• [ ] :warning: - 86 - Detected puts. Remove all debugging statements.
• [ ] :warning: - 96 - Detected puts. Remove all debugging statements.
• [ ] :warning: - 98 - Detected puts. Remove all debugging statements.

[miq-bot]

Checked commit https://github.com/Fryguy/manageiq/commit/aa1d804e6e8b6752eb821e4b2bd3bced7b2ffdd2 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint 2 files checked, 17 offenses detected

lib/tasks/test_security.rake

• [ ] :exclamation: - Line 11, Col 35 - Style/HashSyntax - Use hash rockets syntax.
• [ ] :exclamation: - Line 19, Col 39 - Style/HashSyntax - Use hash rockets syntax.
• [ ] :exclamation: - Line 27, Col 37 - Style/HashSyntax - Use hash rockets syntax.
• [ ] :exclamation: - Line 36, Col 28 - Style/HashSyntax - Use hash rockets syntax.

lib/tasks/test_security_helper.rb

• [ ] :exclamation: - Line 16, Col 5 - Rails/Output - Do not write to stdout. Use Rails's logger if you want to log.
• [ ] :exclamation: - Line 17, Col 5 - Rails/Output - Do not write to stdout. Use Rails's logger if you want to log.
• [ ] :exclamation: - Line 18, Col 5 - Rails/Output - Do not write to stdout. Use Rails's logger if you want to log.
• [ ] :exclamation: - Line 42, Col 5 - Rails/Output - Do not write to stdout. Use Rails's logger if you want to log.
• [ ] :exclamation: - Line 54, Col 5 - Rails/Output - Do not write to stdout. Use Rails's logger if you want to log.
• [ ] :exclamation: - Line 71, Col 7 - Rails/Output - Do not write to stdout. Use Rails's logger if you want to log.
• [ ] :exclamation: - Line 73, Col 7 - Rails/Output - Do not write to stdout. Use Rails's logger if you want to log.
• [ ] :exclamation: - Line 86, Col 7 - Rails/Output - Do not write to stdout. Use Rails's logger if you want to log.
• [ ] :exclamation: - Line 95, Col 14 - Style/HashSyntax - Use hash rockets syntax.
• [ ] :exclamation: - Line 96, Col 5 - Rails/Output - Do not write to stdout. Use Rails's logger if you want to log.
• [ ] :exclamation: - Line 97, Col 18 - Style/HashSyntax - Use hash rockets syntax.
• [ ] :exclamation: - Line 98, Col 5 - Rails/Output - Do not write to stdout. Use Rails's logger if you want to log.
• [ ] :exclamation: - Line 99, Col 16 - Style/HashSyntax - Use hash rockets syntax.

[jrafanie]

the cancelled 3.0 vmdb didn't re-run when I kicked the failed tests... restarting it

[jrafanie]

Merging, whitesource common failure is back: Oops! An error occurred while running the Security Check.The Scanner was unable to connect to the repository or branch and clone it.