fix tools/feature_supports_matrix

[kbrock]

extracted from https://github.com/ManageIQ/manageiq/pull/23140

Overview

I don't know the true purpose of this code. But it was referencing QUERYABLE_FEATURES which went away 5dae6457fc (in 3/15/2021)

I went in here because I was adding supports feature mixin to all models and grep showed me this class

Before

threw exception

After

Lists every model

Alternate

Delete this tool. I know it was used by Martin H, not sure who else would need it.

[miq-bot]

Checked commit https://github.com/kbrock/manageiq/commit/015a7fd527e7e28cd3c754fbfba331a8c8991f99 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint 1 file checked, 3 offenses detected

tools/feature_support_matrix.rb

• [ ] :exclamation: - Line 26, Col 1 - Style/GlobalVars - Do not introduce global variables.
• [ ] :exclamation: - Line 35, Col 7 - Style/GlobalVars - Do not introduce global variables.
• [ ] :exclamation: - Line 63, Col 54 - Style/GlobalVars - Do not introduce global variables.

[Fryguy]

I believe the original purpose of this was so that we could generate the capabilities matrix in the docs. That being said, it might be worth just deleting or, if it's actually used for the docs, move it over to the docs repo? @agrare Thoughts?

[agrare]

I don't know if it was intended to build the docs I think it was just informational. The capabilities_matrix in the docs came years after this tool was introduced.

[Fryguy]

I'd be ok with dropping this tool, though I have to admit it's pretty cool we can create an at-a-glance table.

[Fryguy]

Merging anyway, since the bug is fixed. If we want to delete we can in a follow up PR, and @kbrock it's really up to you. Since you're in this space, maybe this tool it helpful for you.