search

ManageIQ / manageiq

ManageIQ Open-Source Management Platform
https://manageiq.org
Apache License 2.0
1.35k stars 900 forks source link

Fix Marshal.load ArgumentError on ruby3.3 #23219

Closed agrare closed 1 month ago

agrare commented 1 month ago

I ran into this using tab-complete in a rails console on ruby 3.3. It appears that rdoc is passing a proc to Marshal.load and that is causing our initializer monkeypatch to fail.

config/initializers/marshal_autoloader.rb:6:in `load': wrong number of arguments (given 2, expected 1) (ArgumentError)
    from /usr/lib/ruby/3.3.0/rdoc/store.rb:974:in `block in marshal_load'
    from /usr/lib/ruby/3.3.0/rdoc/store.rb:974:in `open'
jrafanie commented 1 month ago

Closed / open after merge of https://github.com/ManageIQ/manageiq/pull/23220

miq-bot commented 1 month ago

Checked commit https://github.com/agrare/manageiq/commit/abc80130cc0c9a507f88e4e7a518c70869c3fce8 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint 1 file checked, 0 offenses detected Everything looks fine. :cake: