search

ManageIQ / manageiq

ManageIQ Open-Source Management Platform
https://manageiq.org
Apache License 2.0
1.35k stars 900 forks source link

Remove task_id from AE deliver_queue #23239

Closed nasark closed 1 month ago

nasark commented 1 month ago

task_id may not be necessary with AE. This can cause issues in the event that there are multiple items in the queue with the same task_id

@miq-bot assign @Fryguy @miq-bot add_reviewers @agrare, @Fryguy @miq-bot assign_labels bug, radjabov/yes?

miq-bot commented 1 month ago

@nasark unrecognized command 'assign_labels', ignoring...

Accepted commands are: add_label, add_reviewer, request_review, assign, close_issue, cross_repo_test, move_issue, remove_label, rm_label, remove_reviewer, set_milestone, unassign

nasark commented 1 month ago

@miq-bot add_labels bug, radjabov/yes?

miq-bot commented 1 month ago

Checked commit https://github.com/nasark/manageiq/commit/2c83bef40dd4d2777f8a72ce6647357ac6bdcab8 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint 2 files checked, 0 offenses detected Everything looks fine. :cake:

Fryguy commented 1 month ago

Backported to radjabov in commit 4d3db8460b5d38058c8eacf3d9861428807266d3.

commit 4d3db8460b5d38058c8eacf3d9861428807266d3
Author: Adam Grare <adam@grare.com>
Date:   Fri Oct 18 09:42:33 2024 -0400

    Merge pull request #23239 from nasark/remove_task_id_ae_deliver_queue

    Remove task_id from AE deliver_queue

    (cherry picked from commit 270b7e0363f0d53ddbd8df8fb68ca44a7ca84d98)