search

ManageIQ / manageiq

ManageIQ Open-Source Management Platform
https://manageiq.org
Apache License 2.0
1.35k stars 900 forks source link

Use Rails.application.credentials instead of deprecated secrets #23254

Closed jrafanie closed 3 weeks ago

jrafanie commented 3 weeks ago

Fixes: DEPRECATION WARNING: Rails.application.secrets is deprecated in favor of Rails.application.credentials and will be removed in Rails 7.2.

Extracted from https://github.com/ManageIQ/manageiq/pull/23225

agrare commented 3 weeks ago

@jrafanie I assume we'll have to do this in all of the providers as well? E.g. https://github.com/ManageIQ/manageiq-providers-vmware/blob/b070f714d1bb4d887479b0de120ca6d1d87d2d48/spec/spec_helper.rb#L21

kbrock commented 3 weeks ago

Yea, I see that Rails.application.secrets is accessed in most providers. Can we add TODOs for each provider here? (Want me to add the TODOs?

jrafanie commented 3 weeks ago

@jrafanie I assume we'll have to do this in all of the providers as well? E.g. https://github.com/ManageIQ/manageiq-providers-vmware/blob/b070f714d1bb4d887479b0de120ca6d1d87d2d48/spec/spec_helper.rb#L21

Thanks, I did see a warning from one of the plugins in core, it might have been the hmc provider. Yes, I expect we'll have to do this throughout the plugins. At this point, I'm trying to get core to work and then I'll move to the plugins.

Yea, I see that Rails.application.secrets is accessed in most providers. Can we add TODOs for each provider here? (Want me to add the TODOs?

Thanks, I'll add it to the the main issue.

Fryguy commented 3 weeks ago

It's all over the place in the providers. Additionally, I think it's in the generator as well

jrafanie commented 3 weeks ago

Thanks, I'll add it to the the main issue.

I added it to https://github.com/ManageIQ/manageiq/issues/23200

Fryguy commented 3 weeks ago

@jrafanie I updated the link in #23200 to be broader.