MangaManagerORG / Manga-Manager

Manga Manager collects useful tools to make managing your manga library easy. (Acts directly on files)
GNU General Public License v3.0
190 stars 18 forks source link

Fetching Online fails for some titles #166

Closed ghost closed 1 year ago

ghost commented 1 year ago

It sometimes fetch for goodbye, eri it does not fetch for sayonara, eri I use ubuntu 22.04 version is ./MangaManager_23_03_04_64ae3ba_linux log:

  File "tkinter/__init__.py", line 1951, in __call__
  File "src/MetadataManager/MetadataManagerGUI.py", line 444, in process_fetch_online
  File "src/MetadataManager/MetadataManagerLib.py", line 235, in fetch_online
  File "ExternalSources/MetadataSources/Providers/AniList.py", line 112, in get_cinfo
    title_english = data.get("title").get("english").strip() or ""
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'strip'
majora2007 commented 1 year ago

I have reproduced this issue and found the following:

Fetch Data found title {'romaji': 'Naze Boku no Sekai wo Daremo Oboeteinai no ka?', 'english': None, 'native': 'なぜ僕の世界を誰も覚えていないのか?'}

The series in question on AniList does not have an English name set and thus we fail to write it out. I will adjust the code so that we fallback to at least something set.