search

MangoAutomation / BACnet4J

BACnet/IP stack written in Java. Forked from http://sourceforge.net/projects/bacnet4j/
GNU General Public License v3.0
182 stars 110 forks source link

BACnet - Vendor Name Issue #58

Open drd888 opened 3 years ago

drd888 commented 3 years ago

The proper value for the vendor ID is returned but the vendor name is not being populated.
I did not quite a bit of static analysis but could not find the issue.

I am using: com.serotonin.bacnet4j.RemoteDevice getVendorName()

splatch commented 3 years ago

The vendorName is pupulated from remote Device object property. Same logic as for vendorIdentifier, its just different type:

package com.serotonin.bacnet4j.type.enumerated;

public class PropertyIdentifier extends Enumerated {
  // ...
  public static final PropertyIdentifier vendorIdentifier = new PropertyIdentifier(120);
  public static final PropertyIdentifier vendorName = new PropertyIdentifier(121);
  // ...
}

It happens that these values are somewhat not matching. For example producer is one firm, but firmware/board for electronics is shipped by another.