MangoFVTT / fvtt-ready-set-roll-5e

A module for faster, easier, and more dynamic rolling in the D&D 5th Edition system for Foundry VTT.
GNU General Public License v3.0
39 stars 18 forks source link

[BUG] Adding additional damage with AE does not include damage types #483

Open maxobremer opened 1 month ago

maxobremer commented 1 month ago

Description When you use an active effect to add extra damage, for example for the divine favor spell, the extra damage is added, but loses its damage type. For divine favor i made an active effect with system.bonuses.mwak.damage ADD +1d4[radiant] image Without any modules it rolled the damage of the attack with the radiant damage separate. image With RSR active the roll used the [radiant] as flavour in the roll but just piled it on the slashing damage. image

Steps to Reproduce

  1. Have only RSR as your active modules
  2. give an actor an affect that grants them additional damage set up like: system.bonuses.mwak.damage ADD +1d4[radiant]
  3. have quick roll for items enabled in the RSR settings for items*
  4. Roll for damage with a melee weapon or whatever you have given extra damage
  5. See that the radiant damage is added as flavour but not as actual radiant damage

*I tested this with only quick roll enabled and with every setting enabled separately. Issue persists as long as you have quick roll enabled even when you use alt to override it. No quickroll enabled=no issue

Versions

Other Modules No other modules

MathewBissonnette commented 1 week ago

It appears the problem is in hooks.js. On line 60, changing CONFIG.DND5E.aggregateDamageDisplay = false; to instead =true fixes the problem.