search

Mangopay / cardregistration-js-kit

Mangopay V2 JS resources for card registration front-end workflow
MIT License
38 stars 34 forks source link

Travis tests run integration #30

Closed gabriellupu closed 7 years ago

gabriellupu commented 7 years ago

Add jasmine runner for phantomjs in order to be able to run the tests on the CI machine.

gabriellupu commented 7 years ago

The build is failing because 2 tests are failing (they are also failing when running locally, in the browser so it's not a infrastructure failure): https://travis-ci.org/Mangopay/cardregistration-js-kit/builds/199267446

2 test(s) FAILED:
Kit should return error from Payline if preregistrationData are incorrect.
Expected false to be truthy.
Kit should return error from leetchi script if registrationData are incorrect.
Expected false to be truthy.

How should we proceed @hobailey ? Do you want me to further investigate the failures?

hobailey commented 7 years ago

OK, thanks very much @gabriellupu. I think it's best that @andrzej-rojek takes a look please, as it was him who originally wrote the tests/kit.

hobailey commented 7 years ago

@gabriellupu tests are passing fine now - are you happy for us to merge in your changes?

gabriellupu commented 7 years ago

done! thanks!