search

MannLabs / alphatims

An open-source Python package for efficient accession and visualization of Bruker TimsTOF raw data from the Mann Labs at the Max Planck Institute of Biochemistry.
https://doi.org/10.1016/j.mcpro.2021.100149
Apache License 2.0
81 stars 25 forks source link

Remove Logging Messages at Import Time #267

Closed Yatagarasu50469 closed 1 year ago

Yatagarasu50469 commented 1 year ago

When parallelizing loading operations in a Ray environment, external libraries are automatically imported in external workers/subprocesses. Since some warnings/info were logged on import (i.e., before there's been a chance to manually define logger filters/limits in the new subprocesses), this produced unnecessary clutter in the terminal/console. Moving the applicable calls to prevent their immediate execution at import time solves this issue.

sander-willems-bruker commented 1 year ago

Thank you for your contribution @Yatagarasu50469 . I changed the PR to dev branch instead of master, will be included in the next release.