search

Mantano / iridium

Unofficial Dart/Flutter port of some of the Readium 2 components
80 stars 27 forks source link

Consider Zip entries with file type bits set to 0 as files #100

Closed sorich87 closed 1 year ago

sorich87 commented 1 year ago

The Zip decoder is unable to read /META-INF/container.xml for some ePub files, including Calibre demo file that can be downloaded from https://manual.calibre-ebook.com/conversion.html#epub-advanced-formatting-demo.

The offending code was copied from the archive package https://github.com/brendan-duncan/archive/issues/21, but the archive package has been updated since then to fix the same issue https://github.com/brendan-duncan/archive/pull/234.

This pull request implements the same fix.

P.S.: Thanks for creating this package, it saved me a lot of time!

jmgeffroy commented 1 year ago

Hi @sorich87, thanks a lot for this fix! Happy to see you're using Iridium. Once again, I'm sorry we currently have no time to really work on it but I hope it will happen someday!

sorich87 commented 1 year ago

Thanks @jmgeffroy ! No worries. It's already helping a lot. I'm using it for a new project and will submit PRs whenever there's an issue.