search

ManuelDeLeon / viewmodel

MVVM for Meteor
https://viewmodel.org
MIT License
205 stars 23 forks source link

Update version of CoffeeScript please #300

Closed tomyo closed 6 years ago

tomyo commented 7 years ago

Hi, the version constrain in this package breaks some functionalities in my app with Meteor@1.6 (require node modules doesn't work), could you please lift the version? Thanks!

ManuelDeLeon commented 6 years ago

I'll update it on the next release (with a fix for a problem Juho found)

tomyo commented 6 years ago

:), awewome, I was afraid it was the end of me and this awesone package.

On Tue, Nov 28, 2017, 15:28 ManuelDeLeon notifications@github.com wrote:

I'll update it on the next release (with a fix for a problem Juho found)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ManuelDeLeon/viewmodel/issues/300#issuecomment-347618372, or mute the thread https://github.com/notifications/unsubscribe-auth/AArP2e0mW3jViqxPWInMy8InACD9Y-h-ks5s7FDfgaJpZM4QnyPY .

-- Tomás Hayes.

satyavh commented 6 years ago

Can I ask what is the problem with updating coffeescript? I'm thinking about forking the repro to do this. This hard version constrain is breaking a lot of code. Thanks

ManuelDeLeon commented 6 years ago

Submit a PR with the fix and I'll publish it.

hluz commented 6 years ago

PRs with minimal changes for meteor 1.6.1 sent (for viewmodel, reactivearray and viewmodel-debug)

ManuelDeLeon commented 6 years ago

Trying to publish the changes asap...

Extracting meteor-tool@1.6.1_1

ManuelDeLeon commented 6 years ago

Done!

Thank you very much hluz.

One thing to note is that I used practical meteor mocha for testing and their libraries still use the old coffeescript so I removed them. What this means is that tests are off o_O