ManuelDeLeon / viewmodel

MVVM for Meteor
https://viewmodel.org
MIT License
205 stars 23 forks source link

6.3.5 .array() throws error #305

Closed aon108 closed 6 years ago

aon108 commented 6 years ago

hey Manuel, i've been using this for a very long time now. Started an app recently but with new version 6.3.5 it always throws error on using .array(). I have only got it to work by dropping to version 6.3.4.

Error is that .array is not a function. Hope this helps. Best Regards.

Template.test.viewmodel({ test1: ["test1","test2","test3"], onCreated: function(){ console.log(this.test1()); var test = this.test1().array(); console.log(test); } })

ManuelDeLeon commented 6 years ago

We updated Coffeescript on viewmodel, viewmodel-debug, and reactivearray ; so be sure to update those as well.

On Apr 8, 2018 3:52 PM, "AON" notifications@github.com wrote:

hey Manuel, i've been using this for a very long time now. Started an app recently but with new version 6.3.5 it always throws error on using .array(). I have only got it to work by dropping to version 6.3.4.

Error is that .array is not a function. Hope this helps. Best Regards.

Template.test.viewmodel({ test1: ["test1","test2","test3"], onCreated: function(){ console.log(this.test1()); var test = this.test1().array(); console.log(test); } })

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ManuelDeLeon/viewmodel/issues/305, or mute the thread https://github.com/notifications/unsubscribe-auth/AED31o3AGglhvzVbwLJyC5Qev5WbzGAaks5tmoaHgaJpZM4TLuct .

jaredloson commented 6 years ago

I'm also getting this error, even after doing a fresh install of everything:

coffeescript added, version 2.0.3_4 coffeescript-compiler added, version 2.0.3_4 manuel:isdev added, version 1.0.0 manuel:reactivearray added, version 1.0.7 manuel:viewmodel added, version 6.3.5 manuel:viewmodel-debug added, version 2.7.2

ManuelDeLeon commented 6 years ago

Please make a repro.

jaredloson commented 6 years ago

Created minimal repo here: https://github.com/jaredloson/vmarraytest

Couple other notes: I'm using Blaze; I'm also seeing the "not a function" error with the .clear() method.

ManuelDeLeon commented 6 years ago

Pick up ReactiveArray@1.0.8

I had to convert it to vanilla JS.

aon108 commented 6 years ago

Hey Manuel,

The version 1.0.8 .array() now has a length of 2. Returns the array as expected at index 0, index 1 now also has the dependants. Which is not expected behaviour.

I've had to downgrade back to 1.0.6 for it to work using previous code.

Thanks

On 3 May 2018 at 00:20, ManuelDeLeon notifications@github.com wrote:

Pick up ReactiveArray@1.0.8

I had to convert it to vanilla JS.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ManuelDeLeon/viewmodel/issues/305#issuecomment-386150708, or mute the thread https://github.com/notifications/unsubscribe-auth/ACzuXDn5x-ZGYqLCNuMfekXTdm_1YmdSks5tuj85gaJpZM4TLuct .