MarcusTXK / pe

0 stars 0 forks source link

Overlapping labels and multiplicity #13

Open MarcusTXK opened 2 years ago

MarcusTXK commented 2 years ago

Expected:

Actual:

nus-pe-bot commented 2 years ago

Team's Response

UML notation variations caused by the diagramming tool: Can be rejected

Does not hinder understanding

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: 1. This is not due to PlantUML's diagram and is due to user error. This can be easily fixed with minor tweaks to the .puml file as seen below:

Example way of doing it (among other ways): image.png

  1. It is very confusing to the reader. It is hard to determine if the "filtered" refers to the Group, UniquePersonList or ModelManager, as well as which multiplicity belongs to which arrow. Note: In the diagram above, the filtered label actually belongs to ModelManager (based on their .puml code), but due to how the diagram looks, I misunderstood thatfiltered belonged to UniquePersonList, while all belonged to ModelManager. This is very misleading.

Code extract from uml diagram:
image.png

In my opinion, this could have been a Low severity bug as it is confusing to read and can cause inconvenience to the reader. However, it can also be considered a cosmetic issue as well. Hence I chose the lower of the two severities (ie. veryLow).