MarcusWolschon / osmeditor4android

Vespucci is a OpenStreetMap editor for Android
http://vespucci.io
Other
381 stars 83 forks source link

Track the provenance of tag edits #1996

Open jidanni opened 1 year ago

jidanni commented 1 year ago

I have an idea for the "42" shortcut. When we push it we see it has filled in several fields for us. However it is rather hard to distinguish which fields it has just filled in from which fields were previously there: they are all the same color.

My idea is whatever it has just filled in for us should be in red characters, or some other color.

Screenshot_20221216-092319_Vespucci.jpg

So here the 172 etc. should be in red (three red characters) until we go in and change it to e.g., 173. Whereupon the 173 would be in three black characters.

This should affect both the Properties panel, and the Details panel.

Of course, if we didn't change the 172, and then uploaded it to the server, it should change into black also.

You might say well then everything should be in one color until we edit it and then it should be a different color, and then the things the app has inserted on its own through ("42") artificial intelligence being a third colour, etc. Well all that is great, but for another day.

simonpoole commented 1 year ago

Tracking the provenance and status of individual tags has the potential to greatly expand the memory requirements of the app, both in memory and on the device storage, not even starting on the complexity of the business logic this would require. So this would be a fairly major undertaking.

jidanni commented 1 year ago

I was just thinking: change 'App insert 172" to 'save pen color; switch to red pen; App insert 172; restore pen color'. Nothing fancy.

simonpoole commented 1 year ago

I was just thinking: change 'App insert 172" to 'save pen color; switch to red pen; App insert 172; restore pen color'. Nothing fancy.

This would vanish literally on the next pause/resume cycle not to mention exiting the property editor and restarting.

simonpoole commented 1 year ago

https://github.com/MarcusWolschon/osmeditor4android/issues/1782 would require the same mechanism, closing that and leaving this open.