search

Marginal / StreamSource

EDMC plugin to produce text sources for use in live streaming software
8 stars 3 forks source link

EDMC Plugin API and 'random' imports #3

Closed Athanasius closed 2 years ago

Athanasius commented 4 years ago

A heads up that things like https://github.com/Marginal/StreamSource/blob/master/load.py#L14 are prone to breakage because nothing on the EDMC side ever documented that plugins are allowed to import 'random' bits of the code to re-use data/constants.

At some point we'll change EDMC code to have all static variables/mappings in a new data.py and that will be explicitly defined as available to plugins. Keep an eye on the #edmc-plugins channel of the EDCD Discord and the following project:

https://github.com/EDCD/EDMarketConnector/projects/2

Athanasius commented 2 years ago

I've now forked this project to -> https://github.com/Athanasius/EDMC-StreamSource - and this issue has been addressed.

The 2.0.0-rc1 release there appears to work, but I only performed a perfunctory check of simply logging into the game and checking the output files.