search

MarginallyClever / weaving_algorithm

weaving thread between nails in a circle to produce an image.
GNU General Public License v2.0
163 stars 48 forks source link

RGB version? #3

Open ofou opened 5 years ago

ofou commented 5 years ago

I was wondering if it's possible to make a RGB version of this algorithm using 3 threads instead of one. It would be amazing if this is possible. Have you thought about it?

i-make-robots commented 4 years ago

I can help. Your issue is not an RGB issue, it is a new issue. use the "new issue" button to start a new thread.

On Thu, Apr 16, 2020 at 9:03 PM Zanevskiy notifications@github.com wrote:

I'm wondering why stuff that isn't about the RGB version is in this thread. Make a new issue, please.

I'm sorry. in my country, very few people understand processing3, I wanted to ask the creators of the sketch for help. if you can not help me then sorry

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/i-make-robots/weaving_algorithm/issues/3#issuecomment-615028734, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALFRBV6ASKH2FFXLW3YD73RM7IJBANCNFSM4IJGABXA .

--

Dan Royer

Owner

1 (604) 259 9564 <16042599564> dan@marginallyclever.com www.marginallyclever.com https://www.facebook.com/MarginallyClever/ https://www.instagram.com/imakerobots/ https://www.youtube.com/channel/UCfbRxqjuOgE2EzRKxcePArw https://twitter.com/MarginallyC https://github.com/MarginallyClever/

Zanevskiy commented 4 years ago

I can help. Your issue is not an RGB issue, it is a new issue. use the "new issue" button to start a new thread. … On Thu, Apr 16, 2020 at 9:03 PM Zanevskiy @.***> wrote: I'm wondering why stuff that isn't about the RGB version is in this thread. Make a new issue, please. I'm sorry. in my country, very few people understand processing3, I wanted to ask the creators of the sketch for help. if you can not help me then sorry — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALFRBV6ASKH2FFXLW3YD73RM7IJBANCNFSM4IJGABXA . -- Dan Royer Owner ------------------------------ 1 (604) 259 9564 <16042599564> dan@marginallyclever.com www.marginallyclever.com https://www.facebook.com/MarginallyClever/ https://www.instagram.com/imakerobots/ https://www.youtube.com/channel/UCfbRxqjuOgE2EzRKxcePArw https://twitter.com/MarginallyC https://github.com/MarginallyClever/

Thank you

Zanevskiy commented 4 years ago

I'm wondering why stuff that isn't about the RGB version is in this thread. Make a new issue, please.

I have an opinion about your algorithm. you have flowers in the algorithm go one after another in a circle: red; blue; yellow ... repeat. people who have achieved quality in a colored thread have a certain amount of one color (say 100 actions of red, 100 actions of blue; 100 actions of yellow ... repeat). since I don’t understand the programming, you can try changing the sketch, what if it works?)

kitor7 commented 4 years ago

Hi! Thanks for everything. Nice to meet you! Lately I’ve been think about a system that starts by placing the threads through the Center first and gradually spiraling outwards. Th is way high detail in the Center is preserved and it’s very quickly apparent if the image is coherent or not.

@i-make-robots Hi! Dan. I think this is a wonderful and correct idea. I guess it will be probably the best version. Do you code it out by this idea? Thank you.

kitor7 commented 4 years ago

@i-make-robots > That’s why now I feel that maybe starting in the Center and winding outwards might work well. The finished area would be off limits to new thread, or possibly there would be extra punishment for crossing the finished zone.

Good idea. So excellent. Wish you success! :)

polemos0108 commented 4 years ago

IMG_20200526_154525 I did it. Thank you for code

i-make-robots commented 4 years ago

Nice! What inspired you? How many strings & nails is that? What is the diameter of the circle? How long did it take? Can I share that on my blog?

On Tue, May 26, 2020 at 1:07 PM polemos0108 notifications@github.com wrote:

[image: IMG_20200526_154525] https://user-images.githubusercontent.com/56480365/82945398-e5b19300-9fad-11ea-9f1f-9edd94ed75b1.jpg I did it. Thank you for code

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/i-make-robots/weaving_algorithm/issues/3#issuecomment-634251000, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALFRBQRH3FHX4WVXSOYLT3RTQOPPANCNFSM4IJGABXA .

--

Dan Royer

Owner

1 (604) 259 9564 <16042599564> dan@marginallyclever.com www.marginallyclever.com https://www.facebook.com/MarginallyClever/ https://www.instagram.com/imakerobots/ https://www.youtube.com/channel/UCfbRxqjuOgE2EzRKxcePArw https://twitter.com/MarginallyC https://github.com/MarginallyClever/

i-make-robots commented 4 years ago

Have you got a straight on shot of the whole thing? One that doesn't cut off the top.

On Tue, May 26, 2020 at 1:41 PM Dan Royer dan@marginallyclever.com wrote:

Nice! What inspired you? How many strings & nails is that? What is the diameter of the circle? How long did it take? Can I share that on my blog?

On Tue, May 26, 2020 at 1:07 PM polemos0108 notifications@github.com wrote:

[image: IMG_20200526_154525] https://user-images.githubusercontent.com/56480365/82945398-e5b19300-9fad-11ea-9f1f-9edd94ed75b1.jpg I did it. Thank you for code

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/i-make-robots/weaving_algorithm/issues/3#issuecomment-634251000, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALFRBQRH3FHX4WVXSOYLT3RTQOPPANCNFSM4IJGABXA .

--

Dan Royer

Owner

1 (604) 259 9564 <16042599564> dan@marginallyclever.com www.marginallyclever.com https://www.facebook.com/MarginallyClever/ https://www.instagram.com/imakerobots/ https://www.youtube.com/channel/UCfbRxqjuOgE2EzRKxcePArw https://twitter.com/MarginallyC https://github.com/MarginallyClever/

--

Dan Royer

Owner

1 (604) 259 9564 <16042599564> dan@marginallyclever.com www.marginallyclever.com https://www.facebook.com/MarginallyClever/ https://www.instagram.com/imakerobots/ https://www.youtube.com/channel/UCfbRxqjuOgE2EzRKxcePArw https://twitter.com/MarginallyC https://github.com/MarginallyClever/

polemos0108 commented 4 years ago

Nice! What inspired you? How many strings & nails is that? What is the diameter of the circle? How long did it take? Can I share that on my blog? … On Tue, May 26, 2020 at 1:07 PM polemos0108 @.***> wrote: [image: IMG_20200526_154525] https://user-images.githubusercontent.com/56480365/82945398-e5b19300-9fad-11ea-9f1f-9edd94ed75b1.jpg I did it. Thank you for code — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALFRBQRH3FHX4WVXSOYLT3RTQOPPANCNFSM4IJGABXA . -- Dan Royer Owner ------------------------------ 1 (604) 259 9564 <16042599564> dan@marginallyclever.com www.marginallyclever.com https://www.facebook.com/MarginallyClever/ https://www.instagram.com/imakerobots/ https://www.youtube.com/channel/UCfbRxqjuOgE2EzRKxcePArw https://twitter.com/MarginallyC https://github.com/MarginallyClever/

this is a girl with pearl earning. painting by johannes Vermeer.

210 points. 8000 lines. Diameter of circle 70 cm. I made it in 2 month. If you want share it I will add more picrures IMG_20200526_154449 IMG_20200526_154501 IMG_20200526_154514 IMG_20200526_160724 IMG_20200526_154532

i-make-robots commented 4 years ago

Not everyone would take the time to do all that work. What inspired you to make it real? That is what I mean by inspiration. :) Looks great! Definitely want to share.

On Tue, May 26, 2020 at 1:56 PM polemos0108 notifications@github.com wrote:

Nice! What inspired you? How many strings & nails is that? What is the diameter of the circle? How long did it take? Can I share that on my blog? … <#m3023057758083446583> On Tue, May 26, 2020 at 1:07 PM polemos0108 @.***> wrote: [image: IMG_20200526_154525] https://user-images.githubusercontent.com/56480365/82945398-e5b19300-9fad-11ea-9f1f-9edd94ed75b1.jpg I did it. Thank you for code — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3 (comment) https://github.com/i-make-robots/weaving_algorithm/issues/3#issuecomment-634251000>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALFRBQRH3FHX4WVXSOYLT3RTQOPPANCNFSM4IJGABXA . -- Dan Royer Owner ------------------------------ 1 (604) 259 9564

<16042599564> dan@marginallyclever.com www.marginallyclever.com https://www.facebook.com/MarginallyClever/ https://www.instagram.com/imakerobots/ https://www.youtube.com/channel/UCfbRxqjuOgE2EzRKxcePArw https://twitter.com/MarginallyC https://github.com/MarginallyClever/ this is a girl with pearl earning. painting by johannes Vermeer. 210 points. 8000 lines. Diameter of circle 70 cm. I made it in 2 month. If you want share it I will add more picrures [image: IMG_20200526_154449] [image: IMG_20200526_154501] [image: IMG_20200526_154514] [image: IMG_20200526_160724] [image: IMG_20200526_154532] — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub , or unsubscribe .

--

Dan Royer

Owner

1 (604) 259 9564 <16042599564> dan@marginallyclever.com www.marginallyclever.com https://www.facebook.com/MarginallyClever/ https://www.instagram.com/imakerobots/ https://www.youtube.com/channel/UCfbRxqjuOgE2EzRKxcePArw https://twitter.com/MarginallyC https://github.com/MarginallyClever/

polemos0108 commented 4 years ago

http://artof01.com/vrellis/works/knit.html

UnderConstruction-eng commented 4 years ago

Hello. May I ask if you are using a canvas that is usually used in painting? Thank you

i-make-robots commented 4 years ago

I have tried painting canvas and off screen buffers.

On Jun 25, 2020, at 6:07 AM, UnderConstruction-eng notifications@github.com wrote:

 Hello. May I ask if you are using a canvas that is usually used in painting? Thank you

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

Neyestan commented 4 years ago

I used a white IKEA kitchen cabinet door.

i-make-robots commented 4 years ago

Oooh, I thought you meant in the code! I have never made one in real life. My results are not satisfying enough for me to try this yet.

UnderConstruction-eng commented 4 years ago

Thank you. Who tried the actual?

On Fri, Jun 26, 2020, 5:41 AM Dan Royer, notifications@github.com wrote:

Oooh, I thought you meant in the code! I have never made one in real life. My results are not satisfying enough for me to try this yet.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/i-make-robots/weaving_algorithm/issues/3#issuecomment-649831924, or unsubscribe https://github.com/notifications/unsubscribe-auth/APWWQJUYLE3IXIFRERF5Q73RYO76ZANCNFSM4IJGABXA .

Neyestan commented 4 years ago

I did. You can see the pictures above.

UnderConstruction-eng commented 4 years ago

If you are using a usual canvas used in painting, does the wood on the canvas strong enough to hold nails?

On Fri, Jun 26, 2020, 4:22 PM Neyestan, notifications@github.com wrote:

I did. You can see the pictures above.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/i-make-robots/weaving_algorithm/issues/3#issuecomment-650052385, or unsubscribe https://github.com/notifications/unsubscribe-auth/APWWQJVGZFMDDSTKI4LZU4DRYRLFNANCNFSM4IJGABXA .

Neyestan commented 4 years ago

No, The tension of threads is high and the canvas can not hold the nails.

UnderConstruction-eng commented 4 years ago

Isn't it that the canvas has a wood in it which is strong enough to hold the nails?

On Fri, Jun 26, 2020, 5:37 PM Neyestan, notifications@github.com wrote:

No, The tension of threads is high and the canvas can not hold the nails.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/i-make-robots/weaving_algorithm/issues/3#issuecomment-650087925, or unsubscribe https://github.com/notifications/unsubscribe-auth/APWWQJWADV3S72NFUNZ75SLRYRT5DANCNFSM4IJGABXA .

Neyestan commented 4 years ago

I've never seen a canvas with a wood at its back, if you find a canvas like that and the wood is strong enough then it works.

i-make-robots commented 4 years ago

Stretching canvas over a board is very doable. Not sure why you'd do it, tho. the canvas will tear when the nails go in. Easier to prime the wood with the paint of your choice.

On Fri, Jun 26, 2020 at 8:24 AM Neyestan notifications@github.com wrote:

I've never seen a canvas with a wood at its back, if you find a canvas like that and the wood is strong enough then it works.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/i-make-robots/weaving_algorithm/issues/3#issuecomment-650239224, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALFRBQ4KUFZVXDAKP6CXDTRYS4SBANCNFSM4IJGABXA .

--

Dan Royer

Owner

1 (604) 259 9564 <16042599564> dan@marginallyclever.com www.marginallyclever.com https://www.facebook.com/MarginallyClever/ https://www.instagram.com/imakerobots/ https://www.youtube.com/channel/UCfbRxqjuOgE2EzRKxcePArw https://twitter.com/MarginallyC https://github.com/MarginallyClever/

UnderConstruction-eng commented 4 years ago

What is the weight of thread you usually use in the actual portrait?

On Sat, Jun 27, 2020, 1:36 AM Dan Royer, notifications@github.com wrote:

Stretching canvas over a board is very doable. Not sure why you'd do it, tho. the canvas will tear when the nails go in. Easier to prime the wood with the paint of your choice.

On Fri, Jun 26, 2020 at 8:24 AM Neyestan notifications@github.com wrote:

I've never seen a canvas with a wood at its back, if you find a canvas like that and the wood is strong enough then it works.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub < https://github.com/i-make-robots/weaving_algorithm/issues/3#issuecomment-650239224 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AALFRBQ4KUFZVXDAKP6CXDTRYS4SBANCNFSM4IJGABXA

.

--

Dan Royer

Owner

1 (604) 259 9564 <16042599564> dan@marginallyclever.com www.marginallyclever.com https://www.facebook.com/MarginallyClever/ https://www.instagram.com/imakerobots/ https://www.youtube.com/channel/UCfbRxqjuOgE2EzRKxcePArw https://twitter.com/MarginallyC https://github.com/MarginallyClever/

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/i-make-robots/weaving_algorithm/issues/3#issuecomment-650306749, or unsubscribe https://github.com/notifications/unsubscribe-auth/APWWQJVM3BTZWP4KVWUOUITRYTMDHANCNFSM4IJGABXA .

Neyestan commented 4 years ago

I used 5000 meter equal to 140 grams, 100% Polyester. https://www.stoffogstil.no/sytilbehoer/traad/overlocktraad-5000-m/sytraad-sort-5000m?RaptorItemClick=True

UnderConstruction-eng commented 4 years ago

I mean, line weight of the thread. Sorry

On Sun, Jun 28, 2020, 10:06 PM Neyestan, notifications@github.com wrote:

I used 5000 meter equal to 140 grams, 100% Polyester.

https://www.stoffogstil.no/sytilbehoer/traad/overlocktraad-5000-m/sytraad-sort-5000m?RaptorItemClick=True

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/i-make-robots/weaving_algorithm/issues/3#issuecomment-650765054, or unsubscribe https://github.com/notifications/unsubscribe-auth/APWWQJQ2PCMFHE5PIPNB7HDRY5E5NANCNFSM4IJGABXA .

Neyestan commented 4 years ago

It depends on the picture but I think 25 is ok, although you can play with it and find the best result.

i-make-robots commented 4 years ago

"A smaller weight number indicates a heavier thread. The weight of a thread is actually a length measurement. Dividing the length of thread by a set weight derives the exact measurement of a thread weight. A thread is labeled 40 wt. when 40 kilometers of that thread weighs 1 kilogram. A 30 wt. thread is heavier because it takes only 30 kilometers of thread to weigh one kilogram. "

Ok, but how does that translate to diameter of thread? The current script is limited to the pixel resolution on the screen and the source image, which is pretty bad when the thread weight is so light. A much thinner thread means the calculation would have to be done off screen in a larger buffer and then scaled down to draw in the view. HOWEVER if that were the case then the whole thing might be done in the GPU at much faster speeds?

Neyestan commented 4 years ago

Hello Dan, It is me again. Have you seen these two links before? http://linify.me/about http://linify.me/

Do you think they can be any help to improve the "color algorithm"?

polemos0108 commented 4 years ago

hi there. i started make another picture. it's vincent. 116870595_2592795601032127_4414636916921106213_o

i-make-robots commented 4 years ago

Nice. I think this script needs to work with images 10x bigger to get more detail with finer thread.

On Fri, Aug 14, 2020 at 9:27 AM polemos0108 notifications@github.com wrote:

hi there. i started make another picture. it's vincent. [image: 116870595_2592795601032127_4414636916921106213_o] https://user-images.githubusercontent.com/56480365/90271230-85bfdf80-de6c-11ea-8418-754819196023.jpg

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/i-make-robots/weaving_algorithm/issues/3#issuecomment-674155824, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALFRBUMIMTPI6BCH7FX2MDSAVQYTANCNFSM4IJGABXA .

--

Dan Royer

Owner

1 (604) 259 9564 <16042599564> dan@marginallyclever.com www.marginallyclever.com https://www.facebook.com/MarginallyClever/ https://www.instagram.com/imakerobots/ https://www.youtube.com/channel/UCfbRxqjuOgE2EzRKxcePArw https://twitter.com/MarginallyC https://github.com/MarginallyClever/

fanqieo commented 4 years ago

hi there. i started make another picture. it's vincent. 116870595_2592795601032127_4414636916921106213_o

Hello, can you provide your code?

Neyestan commented 4 years ago

Hello Dan, Did you see those two links?

polemos0108 commented 4 years ago

Nice. I think this script needs to work with images 10x bigger to get more detail with finer thread. … On Fri, Aug 14, 2020 at 9:27 AM polemos0108 @.***> wrote: hi there. i started make another picture. it's vincent. [image: 116870595_2592795601032127_4414636916921106213_o] https://user-images.githubusercontent.com/56480365/90271230-85bfdf80-de6c-11ea-8418-754819196023.jpg — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALFRBUMIMTPI6BCH7FX2MDSAVQYTANCNFSM4IJGABXA . -- Dan Royer Owner ------------------------------ 1 (604) 259 9564 <16042599564> dan@marginallyclever.com www.marginallyclever.com https://www.facebook.com/MarginallyClever/ https://www.instagram.com/imakerobots/ https://www.youtube.com/channel/UCfbRxqjuOgE2EzRKxcePArw https://twitter.com/MarginallyC https://github.com/MarginallyClever/

if i use bigger image i need more strings. it's hard to make more strings physical.

i-make-robots commented 4 years ago

Agreed!

sanad-lol commented 3 years ago

here is a hint i noticed but i dont know i f it helps or no! before i get to know your great work here i used this code to make some portraits. (https://github.com/christiansiegel/knitter) he used a grey scale image to generate the pattern or the steps. i am not expert put i know that rgb model is not suitable for this project as you mentioned.. instead you used cmyk. i understood that differance between rgb and cmyk kinda of corelated to the brighttness thing.so i compared the numbers you generte in color model..to those in grey scale model ..maybe i will find repeated lines! So the line to choose is the line optained from gray scale model "which represent brightness" and its color is optained from your color model both of the same image. i didnt find a lot of similer lines but it was so colse! just saying and maybe this hint to you some thing! thanks anyway for your efforts<3

sanad-lol commented 3 years ago

hi! it,s me again. but with something more useful this time. i have done more work on the graphic design side of things and i hope you consider it.. there is a select option in photo shop called color range that select similar colors in the photo and turn the photo into clusters like folows: the red color range
red the black color range black the brwon color range brown the green green all togeather all colors ....... in the coding side of things do you think all of that may come togeather i mean instead of using red ,green ,blue, yellow thread we use red brown green and black thread on white background using the photos obtained from photoshop?

i-make-robots commented 3 years ago

Remember that the markers are 100% opaque. Make your layers 100% opaque before putting them together to see what the results might look like.

On Fri, Oct 2, 2020 at 11:23 AM sanad-lol notifications@github.com wrote:

hi! it,s me again. but with something more useful this time. i have done more work on the graphic design side of things and i hope you consider it.. there is a select option in photo shop called color range that select similar colors in the photo and turn the photo into clusters like folows: the red color range [image: red] https://user-images.githubusercontent.com/72053303/94955917-99daa180-04eb-11eb-8b85-73308ce9fe53.jpg the black color range [image: black] https://user-images.githubusercontent.com/72053303/94955948-a959ea80-04eb-11eb-91ba-4a979e28f202.jpg the brwon color range [image: brown] https://user-images.githubusercontent.com/72053303/94955950-aa8b1780-04eb-11eb-87d5-9699fe767af3.jpg the green [image: green] https://user-images.githubusercontent.com/72053303/94955954-ab23ae00-04eb-11eb-92f3-a83e41f657ba.jpg all togeather [image: all colors] https://user-images.githubusercontent.com/72053303/94955945-a8c15400-04eb-11eb-8d6f-df14c109165d.jpg ....... in the coding side of things do you think all of that may come togeather i mean instead of using red ,green ,blue, yellow thread we use red brown green black and black thread on white background using the photos obtained from photoshop?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/i-make-robots/weaving_algorithm/issues/3#issuecomment-702888053, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALFRBQ6NXUABQ27SIZJOR3SIYLA5ANCNFSM4IJGABXA .

--

Dan Royer

Owner

1 (604) 259 9564 <16042599564> dan@marginallyclever.com www.marginallyclever.com https://www.facebook.com/MarginallyClever/ https://www.instagram.com/imakerobots/ https://www.youtube.com/channel/UCfbRxqjuOgE2EzRKxcePArw https://twitter.com/MarginallyC https://github.com/MarginallyClever/

sanad-lol commented 3 years ago

i used the instruction file from each as input and the result is away far 👎 maybe the threads need to be in a layers style .. how much thread in a layer or what layer above the other i cant figure it out Annotation 2020-10-02 222952 in total it takes 7000 thread.. which is a good thing in the other hand

i-make-robots commented 3 years ago

I've been wondering about a method that starts at the center and moves outward. that way the hardest to reach detail is done first.

On Fri, Oct 2, 2020 at 1:43 PM sanad-lol notifications@github.com wrote:

i used the instruction file from each as input and the result is away far 👎 maybe the threads need to be in a layers style .. how much thread in a layer or what layer above the other i cant figure it out [image: Annotation 2020-10-02 222952] https://user-images.githubusercontent.com/72053303/94968100-969de080-0500-11eb-99ea-222952d92224.jpg

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/i-make-robots/weaving_algorithm/issues/3#issuecomment-702948570, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALFRBRCKCEJ3VOIFB4VSIDSIY3N7ANCNFSM4IJGABXA .

--

Dan Royer

Owner

1 (604) 259 9564 <16042599564> dan@marginallyclever.com www.marginallyclever.com https://www.facebook.com/MarginallyClever/ https://www.instagram.com/imakerobots/ https://www.youtube.com/channel/UCfbRxqjuOgE2EzRKxcePArw https://twitter.com/MarginallyC https://github.com/MarginallyClever/

arun-sagar commented 3 years ago

Nice! What inspired you? How many strings & nails is that? What is the diameter of the circle? How long did it take? Can I share that on my blog? … On Tue, May 26, 2020 at 1:07 PM polemos0108 @.***> wrote: [image: IMG_20200526_154525] https://user-images.githubusercontent.com/56480365/82945398-e5b19300-9fad-11ea-9f1f-9edd94ed75b1.jpg I did it. Thank you for code — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALFRBQRH3FHX4WVXSOYLT3RTQOPPANCNFSM4IJGABXA . -- Dan Royer Owner ------------------------------ 1 (604) 259 9564 <16042599564> dan@marginallyclever.com www.marginallyclever.com https://www.facebook.com/MarginallyClever/ https://www.instagram.com/imakerobots/ https://www.youtube.com/channel/UCfbRxqjuOgE2EzRKxcePArw https://twitter.com/MarginallyC https://github.com/MarginallyClever/

this is a girl with pearl earning. painting by johannes Vermeer.

210 points. 8000 lines. Diameter of circle 70 cm. I made it in 2 month. If you want share it I will add more picrures IMG_20200526_154449 IMG_20200526_154501 IMG_20200526_154514 IMG_20200526_160724 IMG_20200526_154532

Hi I guess if you use thin thread the result might look much better or increase the canvas size

polemos0108 commented 3 years ago

Nice! What inspired you? How many strings & nails is that? What is the diameter of the circle? How long did it take? Can I share that on my blog? … On Tue, May 26, 2020 at 1:07 PM polemos0108 @.***> wrote: [image: IMG_20200526_154525] https://user-images.githubusercontent.com/56480365/82945398-e5b19300-9fad-11ea-9f1f-9edd94ed75b1.jpg I did it. Thank you for code — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALFRBQRH3FHX4WVXSOYLT3RTQOPPANCNFSM4IJGABXA . -- Dan Royer Owner ------------------------------ 1 (604) 259 9564 <16042599564> dan@marginallyclever.com www.marginallyclever.com https://www.facebook.com/MarginallyClever/ https://www.instagram.com/imakerobots/ https://www.youtube.com/channel/UCfbRxqjuOgE2EzRKxcePArw https://twitter.com/MarginallyC https://github.com/MarginallyClever/

this is a girl with pearl earning. painting by johannes Vermeer. 210 points. 8000 lines. Diameter of circle 70 cm. I made it in 2 month. If you want share it I will add more picrures IMG_20200526_154449 IMG_20200526_154501 IMG_20200526_154514 IMG_20200526_160724 IMG_20200526_154532

Hi I guess if you use thin thread the result might look much better or increase the canvas size

maybe. i will try next project on bigger canvas.

mojsen commented 3 years ago

Hi @i-make-robots

I used python code to do RGB version. The process i followed is each thread have a copy of original image . so after finding the nail the line drawn is drawn on the copy of image. While calculating the distance i converted rgb to lab and used euclidean distance formula. And to calculate the average of pixels between two nails i used another formula. The results are not so promising Attaching the result. image

Hi. Can you share your code?

arun-sagar commented 3 years ago

Hi @mojsen I don't think my algorithm is efficient . If i crack the most efficient algorithm, definitely i will share the code

arun-sagar commented 3 years ago

Just an Update If you are finding the similarity between two colors using euclidean distance with r,g,b values, it won't yield exact results. Convert r,g,b to Lab or Hsv and use the euclidean distance formula.

i-make-robots commented 3 years ago

I tried it and all it did was slow the calculation. Show evidence if you really think it’s better.

On Apr 18, 2021, at 5:21 AM, arun-sagar @.***> wrote:

 Just an Update If you are finding the similarity between two colors using euclidean distance with r,g,b values, it won't yield exact results. Convert r,g,b to Lab or Hsv and use the euclidean distance formula.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

arun-sagar commented 3 years ago

If we're using the RGB colorspace the difference between 2 colors isn't the same as how humans perceive the difference though. https://stackoverflow.com/questions/9018016/how-to-compare-two-colors-for-similarity-difference

i-make-robots commented 3 years ago

I hear you when you say "well technically there's another way". My experience is that it didn't change the output. Please prove me wrong. Send a pull request with your better version and some screenshots.

On Sun, Apr 18, 2021 at 6:41 AM arun-sagar @.***> wrote:

If we're using the RGB colorspace the difference between 2 colors isn't the same as how humans perceive the difference though.

https://stackoverflow.com/questions/9018016/how-to-compare-two-colors-for-similarity-difference

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/i-make-robots/weaving_algorithm/issues/3#issuecomment-821993472, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALFRBT4EMRJ57AEH5P33LLTJLOQVANCNFSM4IJGABXA .

--

Dan Royer

Owner

1 (604) 259 9564 <16042599564> @.*** www.marginallyclever.com https://www.facebook.com/MarginallyClever/ https://www.instagram.com/imakerobots/ https://www.youtube.com/channel/UCfbRxqjuOgE2EzRKxcePArw https://twitter.com/MarginallyC https://github.com/MarginallyClever/

SachitChawla commented 2 years ago

Hi, I am probably late to the party and you guys have already found a solution to the colored portrait problem. I have note read the code yet but have been very interested in making the colored versions ever since I saw the monochrome ones. My thinking was if you :

Would really love to know where are you with this :)

Cheers!

i-make-robots commented 2 years ago

Hey, thanks for writing. Welcome!

weaving_algorithm_circle uses an octree for color quantization, which is a kind of histogram of any size you want.
There is also a sobel operator used to give edges more importance than areas of flat tone.

The threads are not separated into separate layers. My thinking is to find the thread that will most improve the weaving. Sometimes that's color A, sometimes color B. They weave in and out of each other. Maybe single color per layer is better, I haven't tried it.

Most definitely there is some trial and error. also play with the number of pins, the thickness of string, the transparency of string... Art!

arglin commented 2 years ago

I have tried this colored algo quite a while but I am still struggling. I can share you my idea and my simulation results(these results are adjusted on numberOfCrossingLinesForEachLayer, orderOfColorLayer Manually which is the part I am not satisfied with. I dont have a way to know when to stop and switch color. And also for now the process is dumb---draw different layer once and put them together, it is not practical in production):

Idea of how I did it:

Here are some simulations:

Simulations:

color_2 color_3 color_1

Drawbacks:

really depends on the control of ColorPlatteSections, numberOfCrossingLinesForEachLayer and orderOfColorLayer (black always on top). All are manually set. Those simulations are good results, bad ones are really bad. And because the black layer is always on top, the result is not that colorful because of the black layer is on top.

@i-make-robots Hope this may help, I am also working on it. Thank you for your work, I tried it and it is doing great.