search

MarkHedleyJones / dmenu-extended

An extension to dmenu for quickly opening files and folders.
MIT License
387 stars 33 forks source link

pipx installation failure fix #162

Closed rkollataj closed 1 month ago

rkollataj commented 2 months ago

After successful installation of demu_extended with pipx:

$ pipx install 'git+https://github.com/MarkHedleyJones/dmenu-extended'
  installed package dmenu_extended 1.2.1, installed using Python 3.12.3
  These apps are now globally available
    - dmenu_extended_cache_build
    - dmenu_extended_install_systemd_service
    - dmenu_extended_run

I am getting following error when running it:

$ dmenu_extended_run                                   
Traceback (most recent call last):
  File "/home/remol/.local/bin/dmenu_extended_run", line 5, in <module>
    from dmenu_extended.main import run
  File "/home/remol/.local/pipx/venvs/dmenu-extended/lib/python3.12/site-packages/dmenu_extended/__init__.py", line 1, in <module>
    from .main import *
  File "/home/remol/.local/pipx/venvs/dmenu-extended/lib/python3.12/site-packages/dmenu_extended/main.py", line 7, in <module>
    import pkg_resources
ModuleNotFoundError: No module named 'pkg_resources'

The fix adds missing dependency to pyproject.toml.

MarkHedleyJones commented 2 months ago

@rkollataj Thanks for this update! The CI is failing as the version string in pyproject.toml needs updating to 1.2.2. Are you able to take care of that for me on your branch?

rkollataj commented 2 months ago

@MarkHedleyJones Just pushed incremented version. Hope it will be fine now :-)

MarkHedleyJones commented 1 month ago

@rkollataj So sorry for the delay. There are some issues in CI that need fixing, I'll force merge this for now and fix the issues after. Thank you very much for your contribution.