search

MarketSquare / robotframework-browser

Robot Framework Browser library powered by Playwright.
Apache License 2.0
530 stars 106 forks source link

Add browser and contex be available in the JS extension side #3903

Closed aaltat closed 1 week ago

aaltat commented 1 week ago

Is your feature request related to a problem? Please describe. Add browser and contex be available in the JS extension side.

aaltat commented 1 week ago

Done in #3901

rasjani commented 22 hours ago

Sorry for Q in here but is this a breaking change ? eg, should js extensions be updated to get browser and context arguments too ?

aaltat commented 22 hours ago

Not that I recall, but is something broken?

rasjani commented 20 hours ago

I had js extension that exposed keywords that did not require browser, context or page to be available (some statistics collection) and those keywords cannot be called anymore after 19.0.0 release because of "Browser is closed". Initially i thought the issue was because of missing new arguments messing up before but the fix obviously was to get my stats before closing context & browser ...

So at least there's behaviour change that's related to this (?) and seeing it was labeled for v18.10.0 - i was slightly worried because i didn't see any mention about possible backwards compatibility (albeit, bump to 19 did highlight possible backwards incompatibility changes).

EDIT: After moving my kw calls to happen before browser and context is closed, im still getting huge passrate drop. Debugging. I have hypothesis, i'll file a report after my next testrun finishes..

aaltat commented 19 hours ago

This should not have been changed, but I guess it was. Can you create a separate issue and perhaps with an example that demonstrates the problem.