Taming Needs More Work

[Coraline77447]

Describe the bug I can't tame more than just one companion since I've tried to tame a; Welsh Corgi, Roosterz and Pig. Already have one of the two types of the fairy (blonde I think?) but I already know that I cant tame another fairy due to the taming still in development but now I cant tame more than just one companion in general.

To Reproduce Steps to reproduce the behavior:

1. Tame any one of the current companions
2. Try to tame a different kind of companion
3. Literally see the entity vanish right before your eyes into thin air without a trace and no corresponding item of the second companion in the inventory.

Expected behavior Being able to tame more than just one companion

Screenshots N/A

Debugging latest.log

Is the issue happening in combination with other mods? (If yes, please provide a full list) N/A

Additional context Even tho this problem may have been fixed already but apparently the fix may have cause a much bigger problem than the last..Now I can't tame no more than one companion at a time when I want the fairy (or both the default one and the redhead one)(healer(s), the Welsh Corgi (supporter), and the rooster (guard)...

As I've mentioned above, I'll provide the latest log when I'm finished with my current play session which is still going right now. I am planning on stopping in 15 or so minutes since I've been playing for at least 3-4+ hours already...

[MarkusBordihn]

Thanks for the report. Unfortunately I'm not really able to reproduce the issue on my side see:

Each companion has his own unique ID and only this ID is stored inside the companion item. Which mean it's sound like that some optimization mod kills entities in a close range or adjusting the entity chunk loading.

Could you please try the following to isolate the issue more in detail:

• Create a new world with creative mode and use the spawn eggs to spawn the companion, did they vanish here as well ?
• If not, try to tame these companions and run "/companions list" to see if they are registered to your player?

I will try to add some additional debug information to the log, but could not really reproduce the issue standalone or with my reference mod pack on my side. :(

[Coraline77447]

I currently have two 1.18.1 worlds but they're both different worlds despite them having nearly the same mods and nearly the same amount of mods.

Right now I'm looking in Cora Tinkers' saves folder in it's data folder in Player Companions data folder for the world Cora Tinkers' and this is what I'm seeing;

In there there's my; fairy, welsh corgi, pig, and rooster. The pig and rooster were just test subjects to see If they're bugged as well and I did confirm that they too disappeared when I tamed them.

I have a few questions;

What would happen if I were to delete the data for my welsh corgi, pig, and rooster? Since I don't want the game to constantly keep telling me that they're not registered even tho I've tamed them and everything.

Were you testing this issue in a dev environment or normal environment out of dev environment?

Since it's obvious that the problem won't exist inside dev environment but outside of that type of environment the problem exists.

Not everybody may encounter the issue that I face with Player Companions BUT that doesn't mean that I may be the only one who's experiencing this issue.

"It's sound like that some optimization mod kills entities in a close range or adjusting the entity chunk loading."

I do have some optimization mods installed to help my games overall performace, even with less than 100 mods my performance isn't where it should be and after say 2 or 3 hours of playing the game starts to shutter, stutter, and lag heavily, despite having 8gb of RAM on my machine, using Optifine along with Betterfpsdist, Farsight, Ferrite Core, Ksyxis, and Modern UI that my game still lags badly after 3+ hours, especially when loading into new unexplored chunks.

I am suspecting that Ksyxis may be the perpetratos since in the logs the game keeps telling me something with Ksyxis near the beginning of the log (this was copied from the latest log btw);

"_[03:33:25] [Forge Version Check/INFO]: [ksyxis] Starting version check at https://raw.githubusercontent.com/VidTuGit/Ksyxis/main/forge_updater.json [03:33:25] [Forge Version Check/WARN]: Failed to process update information com.google.gson.JsonSyntaxException: java.lang.IllegalStateException: Expected BEGIN_OBJECT but was NUMBER at line 1 column 4 path $ at com.google.gson.Gson.fromJson(Gson.java:944) ~[gson-2.8.8.jar%2322!/:?] at com.google.gson.Gson.fromJson(Gson.java:897) ~[gson-2.8.8.jar%2322!/:?] at com.google.gson.Gson.fromJson(Gson.java:846) ~[gson-2.8.8.jar%2322!/:?] at com.google.gson.Gson.fromJson(Gson.java:817) ~[gson-2.8.8.jar%2322!/:?] at net.minecraftforge.fml.VersionChecker$1.process(VersionChecker.java:189) ~[fmlcore-1.18.1-39.1.2.jar%23128!/:?] at java.lang.Iterable.forEach(Iterable.java:75) [?:?] at net.minecraftforge.fml.VersionChecker$1.run(VersionChecker.java:128) [fmlcore-1.18.1-39.1.2.jar%23128!/:?] Caused by: java.lang.IllegalStateException: Expected BEGINOBJECT but was NUMBER at line 1 column 4 path $ at com.google.gson.stream.JsonReader.beginObject(JsonReader.java:384) ~[gson-2.8.8.jar%2322!/:?] at com.google.gson.internal.bind.MapTypeAdapterFactory$Adapter.read(MapTypeAdapterFactory.java:183) ~[gson-2.8.8.jar%2322!/:?] at com.google.gson.internal.bind.MapTypeAdapterFactory$Adapter.read(MapTypeAdapterFactory.java:145) ~[gson-2.8.8.jar%2322!/:?] at com.google.gson.Gson.fromJson(Gson.java:932) ~[gson-2.8.8.jar%2322!/:?] ... 6 more"

UPDATE;

Ksyxis really was the cooperate for my issue all along and I'd already took it out and deleted it cause I'd also highly suspected it to be causing most of my performance issues ever since it's version information was failing to process during the forge version check phase at the very beginning of my play sessions for the last few days to a week or more since I'd downloaded and installed Ksyxis to see if it'll improve my overall performance. I'd suspected that it really wasn't helping my performace and now I know that it really was causing this issue with Player Companions! Also what the screenshot shows is like an early warning sign that something isn't right with Ksyxis so I'm glad to have taken it out of my mods lists permanently and won't ever use it ever again!

When I first tried this mod out I did have Ksyxis but I didn't suspect Ksyxis to cause this mess but now it's been removed permanently from my mods lists as well as future mods lists and future versions of Minecraft! Ksyxis may have been poorly writen or something cause it's not as good as optifine. Even tho Optifine is a shitty mod but Ksyxis is a bit worse than optifine!

Ksyxis originally was supposed to be a forge port of one of the fabric optimization mods or a port of one of the optimization mods that's also a fork for one the optimization mods for fabric.

If you want to you may close this report now since I've figured out the root cause of the issue for me and its obviously a mod confliction with the optimization mod Ksyxis. Since Ksyxis kills entities in a close range or adjusted entity chunk loading range to improve perfomance with Minecraft apparently.

Thank you for helping me figure out which mod was causing the issue which I didn't even suspect an issue being caused by one of the mods along with a mod confliction with Player Companions.

Ksyxis may also conflict with Human Companions since I think that Player Companions may have been inspired by Human Companions. I haven't tried Human Companions yet cause of it's commenters were saying that there's some issues with Human Copanions and in it's description says that there's some known issues floating around it that I'll just wait for those issues to be resolved before trying it out. But does Human Companions work alongside Player Companions???

[MarkusBordihn]

Thanks for the update. I released a new version https://www.curseforge.com/minecraft/mc-mods/player-companions/files/3693143 which includes some additional log output to see what it happening.

My ask: Please try to reproduce the issue with this updated version (even without Ksyxis) and send me the log file if you are still see any issues.

Answers to your questions:

The data file includes all of the stats of the tamed companion per player. If you have upgraded from an older version it could be that the data file is corrupt and you need to delete it.

I always testing my mods in different environment like:

• Developer Environment (with Java Debugger / with 10 Mods)
• CurseForge Launcher (with CurseForge Forge Client / with 100 Mods)
• Local Server running in my network (Forge Client / with 200 Mods)
• Live Server running by a ISP with 10 - 20 live players (with 250 Mods)

There are mod developers which are using core and/or mixin modification (because they are easier to implement), which could cause conflicts in other mods. It's always hard to isolate such issues, because they are not easy to spot or to reproduce.

Human Companions should work fine, I added some fix and don't see any issues with it. I personally never heart about Ksyxis as performance mod and could say that I have some experience in this area.

You could try https://www.curseforge.com/minecraft/mc-mods/adaptive-performance-tweaks which is not using any core modding or mixin and handles tasks like entity spawning and item spawning which helps in most cases. You can be sure that this mod is compatible because I use it in all of my tests.