MarkusMcNugen / docker-qBittorrentvpn

Docker container which runs a headless qBittorrent client with WebUI and optional OpenVPN
https://hub.docker.com/r/markusmcnugen/qbittorrentvpn/
GNU General Public License v3.0
171 stars 92 forks source link

Correct start.sh and documentation for use of WEBUI_PORT and INCOMING_PORT environment variables #66

Open 45413 opened 4 years ago

45413 commented 4 years ago

The current documentation references WEBUI_PORT_ENV and INCOMING_PORT_ENV, but these variables are referenced in the /etc/qbittorent scripts as WEBUI_PORT, and INCOMING_PORT respectively.

Additionally, the sed command used to replace existing persistent configs was not properly escaping the \ in the configuration setting name. This caused invalid qbittorent.conf files to be generated when using either of the above mentioned ENV variables. This change will ensure new deployments or changes to the either variables are updated when the container starts.

Once caveat: If you already have an existing qbittorent.conf in your mounted volume, you will either need to edit and add the missing \ in the setting names, or deleted the qbittorent.conf and allow it to be recreated on the next deploy