search

MarlinFirmware / Marlin

Marlin is an optimized firmware for RepRap 3D printers based on the Arduino platform. Many commercial 3D printers come with Marlin installed. Check with your vendor if you need source code for your specific machine.
https://marlinfw.org
GNU General Public License v3.0
16.18k stars 19.21k forks source link

LCD_SET_PROGRESS_MANUALLY requires LCD_PROGRESS_BAR, Graphical LCD, or EXTENSIBLE_UI #18648

Closed mclemmon closed 4 years ago

mclemmon commented 4 years ago

Bug Description

firmware not compiling correctly when trying to use SKR mini E3 v2.0 with Ender3v2 LCD screen.

My Configurations

Marlin.zip

Steps to Reproduce

  1. Disable current LCD option
  2. Enable DWIN_CREALITY_LCD

Expected behavior: compile

Actual behavior: a bunch of errors about not having an LCD.

ellensp commented 4 years ago

This setting definitely errors, But is it in error? Does the .DWIN_CREALITY_LCD work with this setting?

thinkyhead commented 4 years ago

The Ender 3 V2 screen code only displays the SD card progress. It is not yet tailored like the other displays to show the progress set by M73 as an alternative.

ChipCE commented 4 years ago

@thinkyhead I have the same problem but with REPRAP_DISCOUNT_SMART_CONTROLLER . Compiled with 2.0.5.4.

ellensp commented 4 years ago

@ChipCE The REPRAP_DISCOUNT_SMART_CONTROLLER is a character display not a Graphical LCD

ChipCE commented 4 years ago

@ellensp Sorry if I'm wrong. I know it is not the lcd is character display, but is there any reason LCD_SET_PROGRESS_MANUALLY cannot work on the 2004 LCD? I think in Prusa fw they use M73 R[time] to set the remain time.

ChipCE commented 4 years ago

@ellensp sorry for my unclear msg. I mean the 2004 LCD should be able to support LCD_SET_PROGRESS_MANUALLY just to set the remain time with M73. Why LCD_PROGRESS_BAR need to be enabled to use LCD_SET_PROGRESS_MANUALLY ?

ellensp commented 4 years ago

What do you think it should do if you enable LCD_SET_PROGRESS_MANUALLY and then set remaining time with M73?

Technically you don't need LCD_PROGRESS_BAR but you cannot see the value until you turn on the LCD_PROGRESS_BAR feature. And if it didn't tell you to turn it on. you wouldn't know and would wonder why there was no display.

ChipCE commented 4 years ago

@ellensp Thank you! I was thinking that option will replace the default timer with the remain time as in the Prusa firmware.

github-actions[bot] commented 4 years ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.