MarshallOfSound / Google-Play-Music-Desktop-Player-UNOFFICIAL-

A beautiful cross platform Desktop Player for Google Play Music
https://www.googleplaymusicdesktopplayer.com
MIT License
8.28k stars 769 forks source link

Music continues playing on Chromecast when app quits #3790

Open noisymime opened 4 years ago

noisymime commented 4 years ago

OS: MacOS 10.15.3

GPMDP Version: 4.7.1

Issue Descriptions: If I'm casting music (In my case to a Chromecast Audio, but not sure if the device I'm casting to makes a difference) and then quit GPMDP, the music keeps playing. (Assumed) Intended outcome would be that the music stops when the application playing it is quit.

Steps to Reproduce:

Playing music locally (ie not casting it anywhere) works fine, the audio stops immediately when I close GPMDP. Issue is only when casting

welcome[bot] commented 4 years ago

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of duplicate issues on this repo, so please double check now that your issue has not already been solved or doesn't have an open issue already.

To help make it easier for us to investigate your issue, please follow the contributing guidelines and ensure the issue template was filled out.

jespersh commented 4 years ago

It is because you're not actually casting the music, you're casting a playlist and the chromecast actually manages the rest. Try this: Start casting music from your mobile with Google Play Music or Youtube Music. Disconnect your phone from wifi. You'll lose connection to the chromecast device, but the chromecast will continue to play music and the playlists.

I assume google has done this from a userexperience standpoint.

What we could talk about is if the Chromecast should be sent a Stop command as GPMDP is closed.

noisymime commented 4 years ago

I did have a suspicion that it was something like this going on.

Try this: Start casting music from your mobile with Google Play Music or Youtube Music. Disconnect your phone from wifi. You'll lose connection to the chromecast device, but the chromecast will continue to play music and the playlists.

Losing wifi unexpectedly and closing the app gracefully are 2 very different things though. I just tried with both Play Music on my phone and Play Music casting from Chrome on desktop, closing either app causes the music to stop playing which is what I would've thought is the expected behaviour.

What we could talk about is if the Chromecast should be sent a Stop command as GPMDP is closed.

I would strongly suggest that this be considered. It's a somewhat jarring UX to close an application and have 'it' continue doing something (Particularly something like external audio) with no way to immediately stop it without either grabbing another device or restarting the app.

rileym94 commented 4 years ago

I would strongly suggest that this be considered. It's a somewhat jarring UX to close an application and have 'it' continue doing something (Particularly something like external audio) with no way to immediately stop it without either grabbing another device or restarting the app.

I think this is a UX thing, but in the case of a desktop player, I think a stop command would be wise if the program quits, or maybe a prompt to allow the option to stop casting music or let it keep playing?