search

MartenBE / mkslides

Use mkslides to easily turn markdown files into beautiful slides using the power of Reveal.js!
https://martenbe.github.io/mkslides/
MIT License
11 stars 2 forks source link

Hi, mkslides 0.1.35 still has compilation errors, more than one! #21

Closed jaywhj closed 3 days ago

jaywhj commented 3 days ago

Hi, mkslides 0.1.35 still has compilation errors, more than one!

I updated the version and got an error the first time I compiled it.

iShot_2024-11-27_20 03 20

There are no special cases for the configuration items in the mkslides.yml file, and they can be used before the update.

Next I commented out this configuration item in the yml file: separator_charset: utf-8, and other compilation errors appeared.

iShot_2024-11-27_20 06 08

Not sure what this error is about.

Next I checked the configuration items in mkslides.yml one by one, and finally found the reason, it turned out to be the configuration items in revealjs, after the update does not support the configuration of plugin attributes, before the update has always been able to use.

iShot_2024-11-27_21 25 55

I have not added any new configurations for this, they were all available before, is this usage updated?

jaywhj commented 3 days ago

I tested it and found that revealjs configuration item can't have any other plugin's attributes configured inside it, and changing it to another plugin's attributes doesn't work either, only revealjs' own attributes.

MartenBE commented 3 days ago

Could you upload your config file here, so it can be copy-pasted?

MartenBE commented 3 days ago

Also the markdown files

MartenBE commented 3 days ago

I tested it and found that revealjs configuration item can't have any other plugin's attributes configured inside it, and changing it to another plugin's attributes doesn't work either, only revealjs' own attributes.

I could reproduce this, fix is in https://github.com/MartenBE/mkslides/pull/22

jaywhj commented 3 days ago

mkslides.txt

@MartenBE Change the file suffix.

jaywhj commented 3 days ago

The preprocessing feature is great, I tested it and it works great. i don't know how to write Python code, I used Claude to generate it for me, haha, great experience! 👍

MartenBE commented 3 days ago

First issue: separator_charsetdoesn't exist, it is just charset (it was wrong in the README) Second issue, plugin options weren't parsed well: fixed in v0.1.36

Important to note: mkslides currently only supports imports for plugins using public URL's (e.g. CDN's). There aren't many plugins really functional anymore and many are deprecated. Figuring out how each plugin must be loaded from local host is pretty dodgy, thus I am gonna leave that alone for now or wait for a PR from someone. At the moment, mkslides has seen much improvement and is pretty usable as is for now, so it is kinda considered a wontfix for the time being.

jaywhj commented 3 days ago

Okay, thanks. All issues fixed 👍🏻