MartijnBraam / python-isc-dhcp-leases

Small python module for reading /var/lib/dhcp/dhcpd.leases from isc-dhcp-server
MIT License
122 stars 46 forks source link

Fix timezone awareness under Python 2.7.x #33

Closed aaron-sierra closed 4 years ago

aaron-sierra commented 4 years ago

I noticed the build is failing under Python 2.7.x as a result of the changes I introduced in #32...

MartijnBraam commented 4 years ago

I'd hate to break it to you... but python 2.7 is EOL

aaron-sierra commented 4 years ago

I'd hate to break it to you... but python 2.7 is EOL

Don't feel bad about saving me work, unless you mean that you've officially dropped Python 2.7 support in this module. Builds are still happening against Python 2.7 and the README still has instructions for installing for it, too.

I didn't want to be the reason that Python 2.7 stopped being supported.

MartijnBraam commented 4 years ago

Well the change to keep 2.7 supported in this module seems relatively minor. It's probably a good idea to keep support around for that since this code is already written now :)