search

MaslowCNC / Mechanics

Digital Design Files
Other
232 stars 70 forks source link

All_Parts_Laid_Out.svg AngleBrace1 error #53

Closed mrfugu closed 7 years ago

mrfugu commented 7 years ago

In the file "All_Parts_Laid_Out.svg" the patterns (2) for the part called 'AngleBrace1.svg' has a sub-mm inconsistency in its long sides.

This doesn't seem to exist in the "AngleBrace1.svg' file itself, just the "All_Parts_Laid_Out.svg" file. It's minor, but probably adds unnecessary complexity to the tool paths generated for this part using this consolidated file.

-mrfugu

mrfugu commented 7 years ago

Correction: This error appears on the long 90 deg edge of the AngleBrace1 shape, which appears 4x in the " "All_Parts_Laid_Out.svg" file

BarbourSmith commented 7 years ago

Good catch! Thanks for noticing that. If you want to make a pull request which fixes it, I would love to merge it. If not I'll look into correcting the issue.

mrfugu commented 7 years ago

Cool, will do it now.

mrfugu commented 7 years ago

this is my 1st Github contribution, apologies if I made a mess of it. https://www.youtube.com/watch?v=iExgnVXSAuE

mrfugu commented 7 years ago

Well, the file is in my post, but it reads to me like i requested a merge of recently changed files as well, not my intent.

BarbourSmith commented 7 years ago

😀 You ARE helping!

It seems like maybe a bunch of other files got wrapped up in the pull request for some reason, maybe give signing the guest book a go to test the process out

mrfugu commented 7 years ago

Hey, thanks! 

Sorry about that, I’ll read more instructions before any future contributions, hope I didn’t make too big of a mess! 

Cheers,

mrfugu

On Jun 8, 2017, at 4:51 PM, BarbourSmith notifications@github.com wrote:

😀 You ARE helping!

It seems like maybe a bunch of other files got wrapped up in the pull request for some reason, maybe give signing the guest book http://www.maslowcnc.com/howtocontribute a go to test the process out

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/MaslowCNC/Mechanics/issues/53#issuecomment-307223894, or mute the thread https://github.com/notifications/unsubscribe-auth/Ab7YYLN-htNSkFkn56-xOf2ei2OlR3_9ks5sCF7qgaJpZM4N0VF0.

BarbourSmith commented 7 years ago

The beautiful thing about Git Hub is it's virtually impossible to mess anything up. Every change is logged and reversible so you can pretty much always go for it! 👍 👍

mrfugu commented 7 years ago

Ok, I think I got it right this time, I re-submitted the corrected 'All_Parts_Laid_Out.svg' file.

BarbourSmith commented 7 years ago

Just merged it. Fantastic work! Thank you. 👍 👍 👍