search

MatKlucznyk / Qsys

Qsys library for S#P and SIMPL
MIT License
53 stars 18 forks source link

Room Combiner #30

Closed mikaeljay closed 1 year ago

mikaeljay commented 1 year ago

Having an ongoing issue with the room combiner. Have a three wall/four room setup. I've had to where the partition open/closed have gone directly to the room combiner module, and have had it where I tiggered one-shots to the Open or Closed inputs. Using external connection. Any ideas? Thanks in advance.

Michael

MatKlucznyk commented 1 year ago

What issue are you experiencing? Also, is this is an issue that is occurring in a release or the current repository modules?

The Open/Close signals send a command to the core on the rising edge to open or close the wall. For reference, I just checked the modules in the main branch on Q-SYS v9.4.5 LTS and the Open/Close joins seem to be working for me.

mikaeljay commented 1 year ago

My initial issue was fixed with a debouncer on the room partition (non-Crestron product). However, I’m getting this at a different location with the Crestron sensors. This may have nothing to do with anything but you know Qsys pretty/very well so I thought I ask. Also send to Qsys support.

00:00:30.250 {"jsonrpc":"2.0","method":"EngineStatus","params":{"Platform":"Core 110f","State":"Active","DesignName":"WSBA Mountain Room","DesignCode":"lSLP65WLilmG","IsRedundant":false,"IsEmulator":false,"Status":{"Code":5,"String":"Initializing - 11 OK, 4 Initializing"}}}\x00 QsysRX$

00:00:30.250 {"jsonrpc":"2.0","method":"EngineStatus","params":{"Platform":"Core 110f","State":"Active","DesignName":"WSBA Mountain Room","DesignCode":"lSLP65WLilmG","IsRedundant":false,"IsEmulator":false,"Status":{"Code":5,"String":"Initializing - 11 OK, 3 Initializing"}}}\x00 QsysRX$

Just keeps repeating.

Thanks in advance.

Michael

From: Mat Klucznyk @.> Sent: Tuesday, October 3, 2023 4:50 PM To: MatKlucznyk/Qsys @.> Cc: Michael Maland @.>; Author @.> Subject: Re: [MatKlucznyk/Qsys] Room Combiner (Issue #30)

What issue are you experiencing? Also, is this is an issue that is occurring in a release or the current repository modules?

The Open/Close signals send a command to the core on the rising edge to open or close the wall. For reference, I just checked the modules in the main branch on Q-SYS v9.4.5 LTS and the Open/Close joins seem to be working for me.

— Reply to this email directly, view it on GitHub https://github.com/MatKlucznyk/Qsys/issues/30#issuecomment-1745900647 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ANBQDCDVNHXOHTDBUMKWPHTX5SQCDAVCNFSM6AAAAAA5RV6NSOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBVHEYDANRUG4 . You are receiving this because you authored the thread. https://github.com/notifications/beacon/ANBQDCGEF35JNCWFO6F2O5DX5SQCDA5CNFSM6AAAAAA5RV6NSOWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTICBKGO.gif Message ID: @. @.> >

MatKlucznyk commented 1 year ago

That response is sent by the core when a client connects. It looks like the core is closing the connection (it closes the connection after a period of no activity) and the client is re-connecting.

As for the room combiner, it's not entirely threadsafe, so if the triggers are extremely fast it's possible the code will miss an event. The best bet, as you mentioned, is to use a debounce.

MatKlucznyk commented 1 year ago

Im going to close this now but if you need any further support feel free to reach out to me on Facebook or by email (my email is on my GitHub profile).