GitHub actions

[arnaudgolfouse]

Update the github actions to

• Avoid deprecations
• only build the libraries via github actions, reject PRs that modify the libraries.
• Build and test the linux library on ubuntu 20.04. Hopefully this will resolve #114.

Note that this mean that all update to the shared libraries must go through github actions. In particular, they all need a version number... Maybe this should be changed, or we should track this number somewhere, or we should always update the corresponding Godot asset library.

[arnaudgolfouse]

We should probably make a release (update all 3 shared libraries) right after this PR, right ?

[astrale-sharp]

So we'd have to bump a version number each time we make an edit to the code? that sounds okay this seems ready to be merged, do you agree?

[arnaudgolfouse]

Well not exactly, more like everytime we want to put newer libraries on the repository. (Also we don’t have to bump the version number, it’s just here to generate a nice commit message, like "Release 1.2")

but yes, I think it’s ok to merge 🙂

[goblinJoel]

I think it's awesome that you guys are setting this up so non-Rust folks like me can get the updates easier.

A few thoughts:

• Probably remove readme's "You must currently use this in order to support Godot 3.5.1" if you are making an asset library update as well
• Edit the note to "Note: when installing pre-compiled libraries (method 2), we support" to indicate it applies to the from-github method
• On #115 , astrale was concerned about upping the repo size. Does this actually add any new files or just replace ones that are already there? (Personally, I'm not concerned either way, since it looks like the built files are only about 4MB total.)
• You could make the release tagging a manual step if you want to be able to run this job multiple times after changes until you've settled on a final version to release

[arnaudgolfouse]

For point 3, this just update the files. But since those are binaries, the update could end up be quite large (maybe a lot of stuff changes inside ?)… overall not that much of an issue IMO 😄

[arnaudgolfouse]

I'll change the readme. So @astrale-sharp, should I also change the release mechanism? We could make it so can enter any commit message ; this way, we won't be worried about having a version number, we could just update it as we please.

[astrale-sharp]

That sounds great honestly!

---

From: Arnaud Golfouse @.> Sent: Sunday, October 23, 2022 5:46:12 PM To: MatejSloboda/Dijkstra_map_for_Godot @.> Cc: astrale-sharp @.>; Mention @.> Subject: Re: [MatejSloboda/Dijkstra_map_for_Godot] GitHub actions (PR #116)

I'll change the readme. So @astrale-sharphttps://github.com/astrale-sharp, should I also change the release mechanism? We could make it so can enter any commit message ; this way, we won't be worried about having a version number, we could just update it as we please.

— Reply to this email directly, view it on GitHubhttps://github.com/MatejSloboda/Dijkstra_map_for_Godot/pull/116#issuecomment-1288141200, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMZTDKSVSSMNZEMZNBF3YODWEVMUJANCNFSM6AAAAAARMGUVTU. You are receiving this because you were mentioned.Message ID: @.***>

[arnaudgolfouse]

Do you plan on doing a asset store release right after that ? (As in, do you have the rights ? I can't remember...)

[astrale-sharp]

i do :sunglasses: