search

MatmaRex / patchdemo

This repository has been moved to GitLab: https://gitlab.wikimedia.org/repos/ci-tools/patchdemo
https://gitlab.wikimedia.org/repos/ci-tools/patchdemo
MIT License
25 stars 21 forks source link

Notice: Trying to access array offset on value of type null #553

Closed Ammarpad closed 1 year ago

Ammarpad commented 1 year ago

Visiting https://patchdemo.wmflabs.org/ directly throws up these PHP notices

Notice: Trying to access array offset on value of type null in /var/www/html/includes.php on line 231

Notice: Trying to access array offset on value of type null in /var/www/html/includes.php on line 232
MatmaRex commented 1 year ago

I've seen this once or twice, but can't reproduce now.

The error points to the code querying Phabricator task titles. It might be failing when a patch refers to a non-existing task, or maybe a private task?

Ammarpad commented 1 year ago

I think that's correct. I tested the API and it return null for these cases.