Matsyir
commented
2 years ago This could only be reliably tracked for when the opponent chances you (e.g, when you are low health and get chanced), since we can only accurately know the client player's health. For the opponent's health, we would have to estimate it based on what the health bar looks like, and that's very inconsistent, delayed and inaccurate. So your chances could not be as accurate/fair as the opponent's. A bit similar to the DH set issue discussed in #23, I am not too keen on adding stats that are not perfectly fair for both players, or if we do I'd prefer it to be an opt-in config (though there's already so many config options)
That said, I fully support this feature if it's only accurately added for when the local player gets chanced. I could see it being useful to learn by seeing how often you get chanced and aiming to reduce that number / eat more safely.
This feature should be possible with the existing fight data, since each attack from the opponent should include the local player's HP, and the opponent's max hit. Just need to detect and display the chances.
Honestly not among my priorities to implement this, but I'll try and have a look at it next time I work with the plugin, since it shouldn't be that deep to implement. If any devs reading want to try and implement it themselves, go for it! I'll happily accept a PR if it works.
No worries about the labels, only contributors can change them.
18-28
Would it be possible to add a chance counter for every fight?
This would check the max hit of an attack and compare to hp of player attacked at the time of the attack. If max hit > current hp the chance counter would increment by 1.
Also don't know how to add labels to the title, my first time creating a suggestion/issue in github.