search

Matthew-Wise / feature-flagging-umbraco

MIT License
15 stars 3 forks source link

Refactored Data Type/Property Editor #5

Closed leekelleher closed 2 years ago

leekelleher commented 2 years ago

I'd noticed that the property-editor was using an AngularJS view + controller to wrap around the inner data-type, but found from my experiments with Contentment that it could be done using C# code only, (see my PR for a "Custom Value Converter" editor wrapper, if interested?)

I've refactored the code to apply the same approach. This should be backwards-compatible with v1.0.0 of the package.

Hopefully the diffs wont feel too overwhelming - and my coding style isn't too awful, (and my code/whitespace formatting)! 😆 Let me know if you'd like me to explain any of the changes.

leekelleher commented 2 years ago

@Matthew-Wise Thanks for reviewing and merging it in. 🙌

I should have mentioned that I did test it out with Nested Content, and some other editors - I didn't try Block List editor though. It was only when I was hacking around with a wrapper editor for Contentment that I thought I'd take a look how you'd done it here - then once I realised it didn't need the AngularJS files, thought I'd share the knowledge back. 👍