search

Mattie112 / FactoriGOChatBot

A Discord chatbot for Factorio written in Golang
GNU General Public License v3.0
11 stars 5 forks source link

RCON_IP no longer accepts textual DNS names #30

Closed gavento closed 1 month ago

gavento commented 1 month ago

Change 28b880b adds explicit IP parsing with net.ParseIP which only accepts numeric addresses. The previous code also allowed DNS names (resolved automatically to the actual IP in rcon.New), which was very convenient in settings with dynamic IP addresses. Could we please have it back? :-)

Thanks for all the great work on the bot!

Mattie112 commented 1 month ago

Ah, that's a feature I didn't think about :) Yes changing it back to a string is fine by me!

Mattie112 commented 1 month ago

I think this should work: https://github.com/Mattie112/FactoriGOChatBot/pull/31