Mavenomics / MavenWorks

Agile Dashboarding, anywhere
https://mavenworks.com
GNU General Public License v3.0
18 stars 2 forks source link

SlickGrid applies highlight styles twice during render #20

Open quigleyj-mavenomics opened 5 years ago

quigleyj-mavenomics commented 5 years ago

What's happening is a rather maddening interaction between the radio/checklists and the rest of the rendering cycle. The cell differ, after running, sets a changes property and triggers an update on the DataView. The grid then calls an onRowsChanged event, where we handle it by applying highlight CSS styles. Up to now, everything is happening as it's supposed to.

Where things get messy are in the Radio/Checklist runners in setPreviousSelection() that execute immediately afterwards. What they do is invalidate the entire grid (something that was already partially done during the cell highlight update), causing visible studder and showing the grid re-rendering highlights.

This is kinda tricky since the radios/checklists are hacked in there good, and are quite fragile.

Keywords; render twice, slickgrid, highlights, ticking, css

YairMarcowMavenomics commented 5 years ago

We think this is probably in our wrapping and likely be fixed automatically by switching to the latest greatest ~6pac Slickgrid.