search

MaxLeiter / sortablejs-vue3

A thin wrapper around Sortable.js for Vue 3
https://sortablejs-vue3.maxleiter.com
MIT License
364 stars 20 forks source link

Fix vue 2 support #78

Open MaxLeiter opened 1 year ago

MaxLeiter commented 1 year ago

Introduced in #70 that closed #69

MaxLeiter commented 1 year ago

@messenjer are you still going to look into this?

messenjer commented 1 year ago

Hi, @MaxLeiter

The issue is related to Vue sfc (single file component) compilation and Vue-demi

I don't think this is clearly explained on the vue-demi repository and in the articles about it. But, analyzing how the sfc vue compilation works, I don't really see how to say when compiling the sfc that it should mention vue-demi instead of vue.

An issue related : https://github.com/vueuse/vue-demi/issues/139

When you look at the vue-use project which uses vue-demi everywhere they don't use sfc files for their components anywhere.

Look at the new useSortable component: https://github.com/vueuse/vueuse/blob/main/packages/integrations/useSortable/component.ts

The .vue file should be rewritten as a .ts file with definecomponent.

For the moment I won't have the opportunity to look at this, because I'm changing job, I don't have a laptop anymore, but I start my new job on monday, hopefully I'll still be working on vue and there will still be vue2 to vue3 migrations.

If I find the opportunity I'll do it.

Regards

Mathieu

MaxLeiter commented 1 year ago

no worries @messenjer, thanks for looking into it and your contibution. Best of luck with the new job!