search

MaxMaeder / DriveBackupV2

Uploads Minecraft backups to Google Drive/OneDrive or by (S)FTP
https://dev.bukkit.org/projects/drivebackupv2
MIT License
160 stars 49 forks source link

[Bug] DriveBackupV2 Makes More Local Backups Than Limit #177

Closed Minionguyjpro closed 3 months ago

Minionguyjpro commented 4 months ago

Describe the bug

I have set up several backups, for a few folders (autoplug (is for a client called AutoPlug), plugins, root (excluding some files and worlds, this includes most of the server config), world, world_nether, world_the_end). I have set the local keep count to 3, and that works for all of them except for the root/server_config one. That one generates like 10 of them which makes my 50GB space for my container being filled completely immediately. This seems like a bug, as it shouldn't happen and just generate 3. There isn't much to see in the logs (it will say that there is no space left on the device), but I will upload the latest one here anyway.

To Reproduce

  1. Use the same configuration as mine.
  2. Setup automatic backups.
  3. Let it make backups for a while.
  4. Root backup will have more than 3 local backups while it shouldn't.

Screenshots / Videos

No response

Server and Plugin Versions

Logs

https://mclo.gs/LkeaxUe

Says Forge Server Log. That's incorrect as you can see based on the information above.

Config

https://pastebin.com/yESuupAr

Additional Information

No response

Minionguyjpro commented 4 months ago

It says Even if local-keep-count is set to zero, the plugin needs to temporarily create a local backup, while it is set to 3. Weird...

Minionguyjpro commented 4 months ago

I think I found the issue in my config using ./ instead of / for the server_config. I will look for a while now but it should work.

EDIT: Nevermind, seems like I did it correctly with the ..

xiaopangxie123 commented 4 months ago

Hello, I'm also using the latest version of this plugin and may have the same experience as you. I set up a temporary local backup that is automatically deleted after uploading to my OneDrive, but instead of being deleted as scheduled, the backup is stored under "My Backups Path/root". After testing, the plugin automatically deletes the files in the My Backups Path and does not delete the backups in the "root". I'm not sure if this is related to fixing this issue.

lrmtheboss commented 4 months ago

If you are not already, please try the latest dev build from our GitHub actions. This should be fixed in the latest dev build. You may need to manually clear old backups to get it working.

xiaopangxie123 commented 4 months ago

如果尚未尝试，请尝试我们的 GitHub 操作中的最新开发版本。这应该在最新的开发版本中修复。您可能需要手动清除旧备份才能使其正常工作。

It didn't go wrong in the latest dev version, thanks!!!