search

MaxNeedsSnacks / roadrunner

A general-purpose performance mod and fork of the popular "Lithium" mod made for the Forge mod loader.
GNU Lesser General Public License v3.0
24 stars 5 forks source link

incompatibility with EnderMail mod #34

Closed JetpackRescue closed 2 years ago

JetpackRescue commented 3 years ago

Expected Behavior

In the EnderMail mod, you can send packages to a specific xyz coor or to a named locker. So you can send items back to a locker at your base, or to a friends locker.

Actual Behavior

With Roadrunner installed, the packages in EnderMail always get sent to a coord of around -1, 70, -1. Then the next package you send gets sent to -1, 71, -1 and so on, stacking up in the world.. The package does not get sent to the locker, but always to these coordinated. Entering coordinates as the packages destination ends with the same behavior.

Reproduction Steps

Install Road Runner and EnderMail, place locker on ground, right click and name it. place a package on the ground, right click the package with a stamp in your hand, enter the name of the locker you want the package sent to, click done. Then right click the package with a Package Controller and an enderman shows up and takes the package, but delivers it to the wrong place.

I really need both mods for my modpack.

malte0811 commented 3 years ago

The issue seems to be this code in EnderMail, or at least that code is causing an exception in RR. I've never seen this pattern before, I'll do some testing to see if it's actually necessary on 1.16 later.

MaxNeedsSnacks commented 2 years ago

Fixed in EnderMail by malte's PR, thanks for reporting!