search

MaxNeedsSnacks / roadrunner

A general-purpose performance mod and fork of the popular "Lithium" mod made for the Forge mod loader.
GNU Lesser General Public License v3.0
24 stars 5 forks source link

[1.16.5 v1.4] Crash with Create #47

Closed Elfinlocks closed 2 years ago

Elfinlocks commented 2 years ago

Reproduction Steps

I'm encountering this issue with my modpack, Astral Engineering, but should be possible to replicate via simply installing Create and RoadRunner on their latest versions.

https://www.curseforge.com/minecraft/modpacks/astral-engineering/files/3578307

When using Create's pondering system, the game crashed out, citing a rendering error. Removing the RoadRunner mod allows everything to function without issue.

Crash Report File

crash-2021-12-27_09.11.43-client.txt

Additional Information

Here's a link to the Crashy info as well: https://crashy.net/G0nMWJxX5TgG0yeqcKhf

MaxNeedsSnacks commented 2 years ago

Can you try reproducing this with just Create and RoadRunner? The log mentions other mods like the TARDIS mod as well and I want to keep potential error sources to a minimum

malte0811 commented 2 years ago

This looks like a general issue between Create and TARDIS, though it may not be possible to actually trigger it with just those two. Create creates chunks with null worlds, and TARDIS makes the (reasonable) assumption that chunks always have a world attached to them (1, 2).

50ap5ud5 commented 2 years ago

This looks like a general issue between Create and TARDIS, though it may not be possible to actually trigger it with just those two. Create creates chunks with null worlds, and TARDIS makes the (reasonable) assumption that chunks always have a world attached to them (1, 2).

Hello, Tardis Mod developer here. You're right, Create does appear to be doing an unorthodox approach by not attaching a world to their custom Chunk.

From videos involving Create, many other mods that attach capabilities to all Chunks also face this compatibility crash issue with Create.

I have contacted the main developer of Create and from their response it wasn't so clear as to why they did this, just that they had no immediate need to attach a world to their chunk.

A quick fix on a mod developer's side would be to do a null check before attaching capabilites. However, I'm not sure if Create will fix it on their end unless there are enough issue reports that highlight this issue, since their 1.16 versions are no longer being actively updated.

Screenshot_20220201_071254

MaxNeedsSnacks commented 2 years ago

Gonna be closing this issue since this isn't a RoadRunner issue, but thanks for the insights nonetheless ^^