search

MaxOhn / rosu-pp

PP and star calculation for all osu! gamemodes
MIT License
84 stars 39 forks source link

fix end_time for sliders #19

Closed MaxOhn closed 11 months ago

MaxOhn commented 1 year ago

HitObject::end_time currently doesn't give the correct end time for sliders since it's not used in any calculation. Since it's a public function, it should return the correct value though.

MaxOhn commented 1 year ago

Although #20 now provides a way to access slider endtime, the HitObject::end_time method still needs better handling. Making the method private might be the way to go.

MaxOhn commented 11 months ago

Closed by #25