Maximkaaa / galileo

General purpose cross-platform GIS-rendering library written in Rust
Apache License 2.0
360 stars 22 forks source link

Use a dedicated crate for stable vectors in tesselating render bundle #76

Open Maximkaaa opened 2 months ago

Maximkaaa commented 2 months ago

From a discussion in #74, we can replace own implementation of stable vectors that store images and their ids in tesselating render bundle with something implemented in a separate crate and well-tested.

From the PR discussion:

          > Something like `StableVec` or something?..

good guess, I'd say, there is stable-vec which does what we currently implement manually, although the crate docs also refer to the more popular slab crate (by tokio-rs) which might be a more reasonable choice (although I haven't yet used any of them nor read the docs in-depth).

So I would lean towards using slab (haven't checked the deps of it yet).

Originally posted by @lennart in https://github.com/Maximkaaa/galileo/issues/74#issuecomment-2166648238

Maximkaaa commented 2 months ago

@lennart FYI