Maxl94 / ngx-multi-sort-table

MIT License
40 stars 20 forks source link

docs: typos correction in Read.me file #158

Closed kravchenya closed 9 months ago

kravchenya commented 1 year ago

Viele Grüße )

Maxl94 commented 1 year ago

@kravchenya thanks for the PR. Can you please use conventional commits? Thanks

kravchenya commented 1 year ago

@Maxl94 I changed commit's title and added type in front of it.

But apparently don't have rights to restart an action (Lint check on Commit message)

Maxl94 commented 1 year ago

You need to rebase the branch, there is still you initial commit.

image
git rebase -i HEAD^^

Thanks

kravchenya commented 1 year ago

"alle guten Dinge sind drei"

Well, tried to rebase (with dropping initial commit), however doubt that now commit's history looks cleaner

Catscratch commented 9 months ago

Since the repo structure changed and this pr was outdated I created an updated on in #181