search

MaxwellBo / Muncoordinated-2

🇺🇳 Muncoordinated is a Model UN committee management service, (re)written with TypeScript, React, Semantic UI and Firebase.
https://muncoordinated.io/
GNU General Public License v3.0
33 stars 21 forks source link

`master` is broken #178

Closed MaxwellBo closed 2 years ago

MaxwellBo commented 2 years ago

The current Cypress tests are broken because of https://github.com/MaxwellBo/Muncoordinated-2/commit/343ca53a1f8d8a1f450e4af00734373064afba4e. In my opinion just adding some extra elements to a page shouldn't break how a dropdown works, but it seems like maybe it's obscured from Cypress somehow:

CypressError: Timed out retrying: cy.click() failed because this element:

<input aria-autocomplete="list" autocomplete="off" class="search" tabindex="0" type="text" value="">
is being covered by another element:

<div class="text" role="alert" aria-live="polite" aria-atomic="true">Afghani...</div>
Fix this problem, or use {force: true} to disable error checking.

If someone could figure out why they are broken that would be great.

shyambh commented 2 years ago

Hi @MaxwellBo , part of my job is writhing and debugging Cypress tests. I would love to help you out with this.

shyambh commented 2 years ago

Also, it seems that the div[role=combobox] has two children, one is the actual input field that you're filtering for, and another one which is actually a div for the alert that was generated in that field. And Cypress is thinking that this is actually covering up your element. I can fix this, please let me know if I can work on this.

image

MaxwellBo commented 2 years ago

Hi @shyambh! Thanks for taking the time to investigate this!

You're more then welcome to work on this, and it would be a great help! 😄 I've been scratching my head trying fix this specific issue