search

McJtyMods / McJtyLib

MIT License
45 stars 33 forks source link

Fix McJtyMods/RFToolsBuilder#60 #135

Closed iTitus closed 2 years ago

iTitus commented 3 years ago

I didn't test this, but this should fix McJtyMods/RFToolsBuilder#60

McJty commented 3 years ago

I will check this later (after my holiday). Thanks

iTitus commented 3 years ago

Np, enjoy your holidays!

McJty commented 3 years ago

I'll check it out

iTitus commented 3 years ago

There might be an alternative way. Check if the block space is air after the fluid removal and if it is place the replacement.

iTitus commented 3 years ago

And there is also the IFluidBlock API from Forge. I don't think anyone is actually using it, but you never know...

xchgeax commented 2 years ago

I have also encountered this issue and after an hour of remote debugging find out that the problem is actually this lib, I have implemented almost the same solution on the latest build of the lib and the pump card works now. It has been a year already and this bug is known for at least 2 years as of now (McJtyMods/RFToolsBuilder#8). Isn't it a good idea to press a button and merge this at this point so people do not waste their time investigating why pump does not work and having fun with remote debugger instead of playing the game?

@McJty

McJty commented 2 years ago

Oops sorry. Indeed