search

MedKhem / grobid-dictionaries

31 stars 7 forks source link

Firing up Jetty App runs unit tests, despite -Dmaven.test.skip=true...! #30

Closed epugh closed 5 years ago

epugh commented 5 years ago

I'm using Maven 3.6, and when I run:

 mvn -Dmaven.test.skip=true jetty:run-war

All the unit tests are run! However:

mvn -DskipTests jetty:run-war

works as expected.

According to http://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#skip the maven.test.skip isn't recommended, and the solution is to use the http://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#skipTests parameter, ie -DskipTests. I think this could be just a simple documentation fix, and happy to submit a PR for that.

Or I can dig more into the surefire plugin configuration...

MedKhem commented 5 years ago

I've just fixed it for the dev docs and Docker instructions. Thanks for the help!

epugh commented 5 years ago

Saw the fix, thanks.