search

MediaArea / MediaInfoLib

Convenient unified display of the most relevant technical and tag data for video and audio files.
https://mediaarea.net/MediaInfo
BSD 2-Clause "Simplified" License
639 stars 177 forks source link

Suggested updates to PBCore translator #846

Open iamdamosuzuki opened 6 years ago

iamdamosuzuki commented 6 years ago

Have option to pass user-defined values into the PBCore document. For example: allow the user to define the Generation or Location for a document

jlhardes commented 6 years ago

PBCore 1.2 XSD doesn't appear to be correct. Might need to be this: http://v2.pbcore.org/xsd/pbcore-1.2.xsd

JeromeMartinez commented 6 years ago

PBCore 1.2 XSD doesn't appear to be correct.

Please 1 ticket per issue, else it is difficult to track. Copied in https://github.com/MediaArea/MediaInfoLib/issues/851 I'll delete the comment.

JeromeMartinez commented 6 years ago

Have option to pass user-defined values into the PBCore document.

I see a technical difference between passing used-defined values not conflicting with file content or MediaInfo existing fields (including file name), and adding data very specific to an output format.

For example we added support of external metadata for EBUCore, this metadata is not in the file (sponsor needed to inject e.g. identifier, Physical condition, Copyright holder... out of the "ebucore:format" element used by MediaInfo), we did same for NISO Z39.87 output, injecting some EBUCore XML in "mix:Extension" NISO element.

In both cases, we are not replacing content, we are adding content in a separate place, so I need to know if your goal is similar of if you want to replace content. As an example, changing location is not specific to PBCore, as the file name is handled everywhere by MediaInfo. For file name ("Location" in PBCore) replacement, we already have external API for file name information " --File_FileName=(YourPreferedFileNameHere)" but it is limited to "by buffer" interface, when no file name is available (empty file name); limitation is arbitrary (we needed it only in a corner case), we could remove this limitation and permit to change the file name in all cases.

For any other value, we need to check your exact need (adding a pure PBCore thing because it is very specific to PBCore, or generic to MediaInfo so all outputs can use the same API), please provide some examples of what your are trying to do, beside the file name thing.

Generation

I don't see this word in PBCore output.

JeromeMartinez commented 6 years ago

checked with @dericed about details, I add a generic API for injecting data in MI report and @dericed manages PBCore output (mapping between MI report and PBCore output), let's go.