search

MediaMath / t1-python

Python SDK for MediaMath Platform APIs
https://developer.mediamath.com/
Apache License 2.0
18 stars 30 forks source link

Missing Margin Entity #41

Open FodT opened 9 years ago

FodT commented 9 years ago

A todo of missing entities in SDK

pswaminathan commented 9 years ago
pswaminathan commented 8 years ago
FodT commented 8 years ago

Vertical, Audience Segment and Supply Source were added by https://github.com/MediaMath/t1-python/pull/48

FodT commented 7 years ago

the campaign/:id/margins endpoint still returns the legacy xml->json converted format: 

      "prop": [
        {
          "value": "123456",
          "name": "campaign_id"
        },
        {
          "value": "2017-01-19T00:00:00",
          "name": "margin_date"
        },
        {
          "value": "85.0000",
          "name": "margin_pct"
        },
        {
          "value": "2017-01-25T00:43:26",
          "name": "created_on"
        },
        {
          "value": "2017-01-25T00:43:26",
          "name": "updated_on"
        }
      ],
      "name": "campaign Margin 2017-01-19",
      "id": 1542715,
      "type": "campaign_margins_calc"
    }

we'll need this to be consistent with the rest of the json responses before we can add support.

fsargent commented 7 years ago

Related to CAW-3810 (internal)