Meeds-io / MIPs

The Meeds Improvement Proposal repository
0 stars 0 forks source link

Media embedded with iframely in notes #65

Closed margondicco closed 1 year ago

margondicco commented 1 year ago

Rationale

1. Functional Requirements

the following requirements will not be processed in this MIP

Example of integration that would be possible in note : Detailed list and example: https://iframely.com/domains

2. Technical Requirements

This feature will consist in modifying the ckeditor configuration for notes editor.

After having updating this configuration, we must ensure that :

Expected Volume & Performance

Security

Extensibility

Configurability

Upgradability

Existing Features

Feature Flags

Property Name Default Value Target Audience Functional Behaviour

Other Non Functional Requirements

3. Impacts

Documentation

Training

4. Software Architecture

Security

Access

Services & processing

Data and persistence

Multitenancy

Integrations

Migration strategy

5. Annexes

margondicco commented 1 year ago

Hello @rdenarie could you prepare the technical part ?

cc @srenault-meeds

rdenarie commented 1 year ago

In notes, remove the automatic generation of the thumbnail after pasting a URL

Remove plugin autoembed => complexity : low

In notes, remove the video insertion plugin

complexity : low

In note, integrate the native Ck editor media embed component connected to our iframely installation

Add plugin embed or embedsemantic. I didn't find any difference between

In note, ensure that the embedded media is displayed in consultation view

complexity : medium

In note, ensure the ability to edit embedded media in editing mode

We need to resolv previous point to see how to do this one. complexity : medium

In note, enable resizing of the embedded media

This is not possible with both plugin embed or embedsemantic. It is a feature required for a long time in ckeditor (https://github.com/ckeditor/ckeditor5/issues/6593#issue-597548484) If we want to do that, we need to override ckeditor existing plugin complexity : high

Nice to have : Iframely, depending on the embedded source, can offer additional display options. enable the ckeditor component to be extended to allow editing of these additional parameters ; size, start from, end on

This is not possible with both plugin embed or embedsemantic. If we want to do that, we need to override ckeditor existing plugin complexity : high

plamarque commented 1 year ago

ETA begin of october

rdenarie commented 1 year ago

Technical requirements added. No other changes needed.

CC @boubaker for go tech

rdenarie commented 1 year ago

After further discussion, fonctional requirements of this MIPs are included in meedsio/MIPs#71 I close this one.