search

MegaMek / mekhq

MekHQ is a java helper program for the MegaMek game that allows users to load a list of entities from an XML file, perform repairs and customizations, and then save the new entities to another XML file that can be loaded into MegaMek.
http://megamek.org
131 stars 168 forks source link

[49.19 Nightly] ASF units are not being tracked correctly by MHQ/StratCon #3882

Closed Thom293 closed 5 months ago

Thom293 commented 6 months ago

Title. I have a wing of 2 ASF in my TOE. They dont show in the unit rating, and dont appear as options on the SC map to deploy or reinforce with. (They DO show up in the transport capacity report, however). I assume somehow related to recent ASF changes.

May be related to #3861

Screens are Unit Rating, Transport Capacity, and SC map showing they dont show up as deployable from SC map (can deploy them from TOE though).

image image image

Crazed Profanity30690705.cpnx.gz

Customs.zip

Thom293 commented 6 months ago

Ok. So advanced a few weeks and my ASF "Arc Wing" got pulled as a seed lance for a ground battle. So I guess it somehow sees them as a ground unit? Not sure. Just another datapoint.

image Crazed Profanity30690719.cpnx.gz

robgrahamau commented 6 months ago

Have the same happening in 49.18, something I noticed though is that it doesn't seem to be recognizing the Aerospace units as being able to be assigned to transport either:

image

There is more than enough aerospace carriage in this unit (it has multiple overlords plus a Riga II (SLDF campaign) but I can't assign any of them and when you look at the TO&E summary like above

Fighter Bays: 0 needed / 50 available (plus 9 excess Small Craft)

Yet if you look at Transport Capacity Report..

image

It shows 24 Occupied of the 50 available.

Sleet01 commented 6 months ago

@robgrahamau I believe the ASF transport assignment issue you are seeing has already been solved in 0.49.19-dev. If you have a chance, please see about downloading a recent Nightly build and checking that (you can get assistance on the Discord if necessary).

@Thom293 I have a fix for the report issue, but it looks like the RAT / ASF misallocation issue is rooted in MM code rather than MHQ. That will require a separate fix in the MM codebase, which should be up soon as well. There was also an issue with random unit generation for ASF; that will also be fixed.

Regarding deploying the ASF from the StratCon map, I was unable to make that work but perhaps I don't know the right preconditions. I was able to add the Arc Wing contingent to missions via the TOE, as you reported.

Sleet01 commented 6 months ago

There may also be an issue derived from these problems where AeroSpaceFighter units are listed under salary expenses rather than upkeep / maintenance; I'll see if I can repro that.