MegaMek / mekhq

MekHQ is a java helper program for the MegaMek game that allows users to load a list of entities from an XML file, perform repairs and customizations, and then save the new entities to another XML file that can be loaded into MegaMek.
http://megamek.org
134 stars 173 forks source link

NullpointerException error when choosing not to control the battlefield #5246

Open BTSS88 opened 6 days ago

BTSS88 commented 6 days ago

Prerequisites and Pre-Issue Checklist

Severity *

Medium (Gameplay Limitation): Non-core functionality is impaired, providing a suboptimal but playable experience.

Brief Description *

Screenshot 2024-11-25 121359

Encountered this error message at the end of the post-battle report if I choose NOT to control the battlefield. If I choose to control the battlefield, everything progress normally.

Steps to Reproduce

Load MekHQ file; load MM file from mission Recon Evasion; end combat; choose NOT to control the battlefield and click Finish in the post battle briefing window.

Operating System *

Windows 11

Java Version *

17

MekHQ Suite Version *

Free Text (type manually)

Custom MekHQ Version

50.01

Attach Files

logs (2).zip [customs.zip](https://github.com/user-attachm Musket's Emergency Contractors30620416.cpnx.gz ents/files/17896278/customs.zip)

Final Checklist

BTSS88 commented 6 days ago

It looks like a few files didn't upload so I'm trying again.

customs.zip Musket's Emergency Contractors30620416.cpnx.gz

IllianiCBT commented 6 days ago

This appears to be working as intended. Currently, the civilian tables are very small so we frequently run into issues where units fail to generate because no units exist of the type we're asking for. In those events we start lowering our strictness, first by removing roles (Civilian, in this case), then weight, then the final fallback is to default to Mek (for ground scenarios).

That's what happened here, however any other units were then culled out by the old culling method. That has been completely reworked in #5247.

Closing: working as intended.

IllianiCBT commented 6 days ago

Apparently I am far more tired than I realized. Re-opening.

IllianiCBT commented 6 days ago

So, the really odd thing with that scenario is it has no OpFor. How did you assign units to this scenario?

BTSS88 commented 5 days ago

Always via stratcon's traks. I did not deploy them like AtB.

On Tue, Nov 26, 2024 at 3:27 AM Daniel L- @.***> wrote:

So, the really odd thing with that scenario is it has no OpFor. How did you assign units to this scenario?

— Reply to this email directly, view it on GitHub https://github.com/MegaMek/mekhq/issues/5246#issuecomment-2498484732, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4TL2U3CDD5ZWT42C4WXPSL2CNFYNAVCNFSM6AAAAABSM5K27OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJYGQ4DINZTGI . You are receiving this because you authored the thread.Message ID: @.***>